ruslo / sugar Goto Github PK

set sugar ios arch using variants, it's fixed now (?)

http://stackoverflow.com/a/4937486/2288008
http://www.cmake.org/Bug/view.php?id=11667

Support install(TARGETS ... EXPORT ...) and install(EXPORT ...) commands for fake sugar ios targets.

• https://github.com/forexample/package-example

Is there any particular reason not to support plain C compiler in the sugar_generate_warning_flags function? I changed line 28 from

set(is_gcc ${CMAKE_COMPILER_IS_GNUCXX})

to

set(is_gcc ${CMAKE_COMPILER_IS_GNUCXX} OR ${CMAKE_COMPILER_IS_GNUCC})

and it and it seems to work just fine so far.

Thanks for the nice module!

test/fix (?)

http://public.kitware.com/Bug/bug_relationship_graph.php?bug_id=14736

To reproduce, create a directory foo. Run the script as below. It will fail with this error.

Assumption: NoneType object is not iterable is quite often a sign of some non-defensive code. In the particular case, its the args.exclude_dirs being accessed in an unsafe manner, as an iterator, with no default set for exclude_dirs = []. I'd suggest either set default args for exclude_dirs, or check first: if args.exclude_dirs is not None:

$ python generate_sugar_files.py --top ./foo/ --var MYPROJ_SOURCES
Traceback (most recent call last):
  File "generate_sugar_files.py", line 159, in <module>
    Generator.run()
  File "generate_sugar_files.py", line 156, in run
    generator.create()
  File "generate_sugar_files.py", line 116, in create
    for x in args.exclude_dirs:
TypeError: 'NoneType' object is not iterable

NOTE: The same command above works if I pass an --exclude_dirs argument to a valid directory to exclude.

add namespaces and git sha1 support (+ submodules example)