Git Product home page Git Product logo

Comments (7)

matthewpetch avatar matthewpetch commented on June 19, 2024 3

If someone were to do it, would you decline the PR Adam?

I see no reason for it not to be added if someone writes it. Most other clients have it and it'd be nice to see what most other people see when players use !kc commands in-game (even if it isn't trustworthy). An API from Jagex would be nice, if it ever happens.

from runelite.

Adam- avatar Adam- commented on June 19, 2024 1

As discussed on discord, the reason why this probably won't be done is that it is too hard to prove when you have gotten a kill. Probably will have to wait for Jagex to release an API for this.

from runelite.

Noremac201 avatar Noremac201 commented on June 19, 2024

Wouldn't it only work with RuneLite users?

from runelite.

l2- avatar l2- commented on June 19, 2024

yes, it is possible to get (and even set) killcount info from osbuddy services with a guest token but adam is not a fan of the idea.

from runelite.

Adam- avatar Adam- commented on June 19, 2024

I spoke to matthew about us pulling kc data from OSB. He said he is okay with us pulling data, but not submitting data until they can get some sort of verification in place. So, I would be okay with just showing the kill data from them but not submitting new kills.

from runelite.

deathbeam avatar deathbeam commented on June 19, 2024

Ah cool. So this means we can do following:

On "!kc" command:

  1. Get kc data from OSB
  2. Get kc data from RuneLite
  3. Compare OSB and RuneLite data
  4. Store OSB data if they are higher kc to RuneLite
  5. Display RuneLite kc data

On kill/house check/row check:

  1. Determine boss
  2. Store kill count to RuneLite database

This requires:

  • Service for accessing OSB kc data
  • Making own RuneLite database for kill counts
  • Find a way how to extract data from ring of wealth and house adventurer's log (from kill it is easy, just parse chat message)

Sounds doable.

from runelite.

Adam- avatar Adam- commented on June 19, 2024

Added in #4067

from runelite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.