ruby-protobuf / protobuf-core Goto Github PK

We definitely want this project building on Travis CI

The Rubinius build on Travis is currently breaking the encoding extreme values. I don't use Rubinius on any of my projects, so I probably won't be dedicating time to fixing this.

https://travis-ci.org/ruby-protobuf/protobuf-core/jobs/63685695#L597

In order to generate ruby code that can talk RPC we need to make our compiler from protobuf-core be extensible so that protobuf-rpc can tell it what to generate for services and rpc calls.

Before we go down the road of changing what code gets generated by protobuf-core I thought it would probably be valuable to create protobuf-core, protobuf-rpc and protobuf-zmq in a form that matches the current protobuf gem. We can keep the version numbers in the 3.X series and just get the code organized into the new shape we want. Then we can start to experiment with changing what code is generated etc.

Does this sound like a good plan? If so I will make a 3.X milestone and create some issues to track what I'm working on and I'll defer experimenting with the generator until we get things to a workable state.

/cc @localshred @liveh2o

Right now we are generating protobuf files that include rpc related functionality which will not work if you tried to use that file with protobuf-core.

In order to catch these types of errors lets add 1 end-to-end test that takes a protobuf definition, compiles it to ruby, loads the ruby file and then encodes/decodes some messages with that ruby class.