Binary files not listed in the diff about diff2html HOT 12 CLOSED

Hi @rmpestano , apparently I broke it with the last fix.
The parser was missing a test for binary files.

Will release a fix soon.

from diff2html.

great 👍

from diff2html.

@rmpestano released as version [email protected]

from diff2html.

Its working great now, thank you very much!

from diff2html.

Hi again @rtfpessoa,

Although it is working I'm getting the following javascript error (only when there are binary diffs):

Failed to parse lines, starting in 0!startBlock @ diff2html-2.0.0-rc.9.min.js:3

Attached a zip containing a sample.

diff2html-sample.zip

from diff2html.

That is "expected" behaviour.

If I cannot find @@ ........ @@ I log that error.

Maybe I can log it only If the line starts with @ and ignore it there is no such line, like in binary files.

from diff2html.

@rmpestano just did a quick fix for the binary files.

BTW, also released major version 2.0.0 after the first fix (for more than a month to do it).

So this fix is in [email protected].

from diff2html.

@rtfpessoa, working without errors now, thank you again 👍

from diff2html.

@rtfpessoa is there a flag to ignore binary files? seems to be a good usecase.

from diff2html.

@rahulnjs can you provide more context about your use case?

You can do that when generating the diff, or you can even do:

1. Parse diff string to json using diff2html
2. Filter binary files from the json
3. Generate html using diff2html with the filtered json

In general I think it would be too simple to do outside, cannot find a good use case to bundle that.
Let me know if you have more information.

from diff2html.

@rtfpessoa I understand your point.

But when diff2html is already doing so much wouldn't it be nice to filter it during parsing or even during html generation. Which would save me all the 3 steps you have mentioned. So the code remains clean.

All I have to pass is,

{
     ignoreBinary : true | false
}

Thanks.

from diff2html.

@rahulnjs when you say:

when diff2html is already doing so much

I am not sure what you really mean.
Today diff2html only does parsing of diffs and html generation. At most you can configure some important features of each of these features.
If we start adding too many unrelated features it will easily get bloated and over-complicated.

I think what you are requesting is mostly a feature of the diff generation, since it makes no sense to generate it for files that you are not interested to see.

Sorry to be too persistent but I really would like to avoid getting to many things in here.

from diff2html.