Git Product home page Git Product logo

Comments (4)

rtfpessoa avatar rtfpessoa commented on June 22, 2024 1

Published v3.4.41 with the fix

from diff2html.

rtfpessoa avatar rtfpessoa commented on June 22, 2024

Weird, are you sure the plugin is using the latest diff2html version?
Some versions ago I did some improvements in this area.

Also now you can even provide overrides for languages like this

- `highlightLanguages`: Map of extension to language name, used for highlighting. This overrides the default language

I think you need to ask for support from the plugin dev not much I can do here as it does not seem like a problem.

If you really think it is a diff2html problem, feel free to re-open but provide some extra details.

from diff2html.

scfrazer avatar scfrazer commented on June 22, 2024

Thanks for the update, I'll see if I can debug the issue more, maybe use the suggestion you gave above for highlightLanguages. I'll re-open if there seems like something is generic enough to perhaps be in this code instead.

from diff2html.

scfrazer avatar scfrazer commented on June 22, 2024

Hey, @rtfpessoa I think this issue should be re-opened. I just submitted a PR with a simple change to avoid causing problems in libraries that use the slim version of diff2html. I am new to the GitHub PR process so hopefully I've done everything correctly.

BTW I originally tried going down the route you suggested using highlightLanguages. I can't remember the details off the top of my head, but there was an issue that the subclass that has the highlightLanguages member wasn't exported so it was not externally usable. I'm not an expert so maybe I messed up, but FYI there may be an issue there as well.

from diff2html.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.