Fix diff parsing on windows line ending about diff2html HOT 5 CLOSED

It also has an impact when receiving the diff via a <textarea> html element. Textarea uses CRLF line endings.

from diff2html.

@pbu88, any suggestions of libs to perform the EOL conversion?

from diff2html.

Hmmm I think this is fair easy fix. At some point in the parser we do this:

//dir-parser.js line 125
var diffLines =
  diffInput.replace(/\\ No newline at end of file/g, '')
    .split('\n');

So we could basically change all the \r\n into \n or we could do a smarter split.

from diff2html.

That seemed like a very aggressive way. But maybe it is simple enough to try it.

from diff2html.

Well, I think this is a relatively easy to fix issue. Using an external library might be overkill. Maybe I'm failing to see a future issue that this fix might involve.

from diff2html.