TypeError: diffInput.replace is not a function about diff2html HOT 6 CLOSED

Hi @arnaspet,

I found a possible bug in the diff2html-ui leading to a possible bad behaviour.

You can avoid it by explicitly passing the inputFormat, and you can also use $(this).

        var diff2htmlUi = new Diff2HtmlUI({diff: $(this).data('diff')});
        diff2htmlUi.draw($(this), {
            inputFormat: 'json',
            matching: 'lines'
        });

When I get some time I will review the API and see if there are any more problems. In the meanwhile try that fix.

from diff2html.

ok thanks,
also it creates only empty wrapper:

<div class="d2h-wrapper">

</div>

when i added "--- a/sample\n+++ b/sample\n" to start of string only then it started working.

from diff2html.

@arnaspet do not close this for me not to forget to fix the previous problem.

Regarding the diff. That is expected. I only support unified diffs or the extended git diff version.

So you need to at least have :

--- oldfilename
+++ newfilename
@@ .... @@
body

Your diff is currently not a valid unified diff.

Read more about it here:
http://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html#Detailed-Unified

from diff2html.

@rtfpessoa Thanks ! Sorry for closing, missclicked it.

from diff2html.

@arnaspet no problem 😄

from diff2html.

Fixed in d3b053c

Will be released soon.

from diff2html.