Identify and add Type Guards to methods that return a boolean about andculturecode.javascript.core HOT 9 CLOSED

I imagine there could be more instances where we could use this but figured it's a good start with the ones that have been identified so far.

from andculturecode.javascript.core.

Can I be assigned to this issue? Thanks

from andculturecode.javascript.core.

Oh, sweet! I think I understand - so for the CollectionUtils methods, this will alleviate the need to use the forced non-null operator (!) on results that have been passed through it?

from andculturecode.javascript.core.

Oh, sweet! I think I understand - so for the CollectionUtils methods, this will alleviate the need to use the forced non-null operator (!) on results that have been passed through it?

Exactly! 👏

from andculturecode.javascript.core.

Type guard can be done easily for single parameter (i.e. isEmpty(value?: string)) but not for rest parameter (hasValue(...collections: Array<T>)

I am looking to see if there are some user defined type guard for this case

from andculturecode.javascript.core.

@dtnhinh Let me know if you find anything that can help narrow down type guards for a rest parameter. If we can't, I'm not opposed to updating the signature of that function to take a single 'collection' - I believe the rest parameter was added to solve some tedious resultObject/API response checking in a complex component for an internal project, but I haven't seen it widely used since. It would be a breaking change, do we feel like the compiler type guard outweighs the rest parameter?

from andculturecode.javascript.core.

I have done some researches but I don't think there is a type guard workaround for rest parameter. I have never seen a case where we parse multiple arguments rather than one single array so I can't say if rest parameter would ever be useful in the future use. Array type guard is very common so let me know if you think we should switch to single collection

from andculturecode.javascript.core.

Let's just switch to a single collection @dtnhinh. If we really need one with a rest parameter/multiple collections at once, we can open up a new issue and add in separate function(s) to accomplish that. I think the type guard is a huge advantage for developer ease of use 👍

from andculturecode.javascript.core.

Published with v0.4.0

from andculturecode.javascript.core.