StringUtils.isEmpty type guard types value as 'never' when false about andculturecode.javascript.core HOT 7 CLOSED

Hey @brandongregoryscott, sorry for holding you back. I actually haven't looked into this issue. Let me get back to you this afternoon on this.

from andculturecode.javascript.core.

Yup. value?: string with type predicate value is "" is equivalent to value: null | undefined | string with type predicate value is null | undefined | '' so the optional parameter actually helps taking care of that. PR is coming in a bit

from andculturecode.javascript.core.

I will look into this

from andculturecode.javascript.core.

Thanks @nhinhdao! No rush, I was just excited to use the new guards! 😂

from andculturecode.javascript.core.

@nhinhdao How's this coming? I am holding back on pushing out a new version w/ the JSDoc + RecordUtils type guard since it won't be of much use with the way the type guard for isEmpty currently stands

from andculturecode.javascript.core.

@brandongregoryscott I have found the workaround for this case by using literal type for string;

this type predicate will narrow value to be null | undefined | '' which works well for this case

from andculturecode.javascript.core.

Woah, that's awesome 👍 Is it actually bound to null | undefined | '' with the type guard of value is ''? As long as we don't have to start non-null asserting after isEmpty returns false, then we should be good to go. Do you want to send out a PR for this, or would you like me to pick it up?

from andculturecode.javascript.core.