rsc / github Goto Github PK

I got a panic while running issue -a.

This line failed to print the error message https://github.com/rsc/github/blob/master/issue/acme.go#L70. I eventually figured I had to add

plumb to githubissue

to ~/lib/plumbing but that's not in the documentation. The panic trace is similar to the below (similar because line number is influenced by some print's I've added).

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x230 pc=0x7b6509]

goroutine 21 [running]:
9fans.net/go/acme.(*Win).Err(...)
	/home/nicolagi/go/pkg/mod/9fans.net/[email protected]/acme/acme.go:895
main.(*awin).plumbserve(0xc0000a8480)
	/home/nicolagi/go/src/rsc.io/github/issue/acme.go:71 +0x149
created by main.acmeMode
	/home/nicolagi/go/src/rsc.io/github/issue/acme.go:62 +0x1f7

Currently, issue defaults to the golang/go repo and there exists no way to change this. This means those using issue and not working on that repo must frequently supply a -p user/repo. I think it would be nice if issue was a little "smarter" about the repo I'm interested in and so I propose adding smarter defaults using the following rules, each overriding the next:

• issue commands use -p if supplied
• issue commands default to git config github.issue.repo.always if supplied
• issue commands default to the origin repo if supplied and its host is github
• issue commands default to git config github.issue.repo if supplied
• issue commands default to golang/go if none of the above are satisfied.

I'm not married to the git config names.