royallthefourth / bartlett Goto Github PK

A query shouldn't take very long to turn around. Add a time.Duration and a mechanism for cancelling slow requests. Perhaps a context deadline is appropriate here?

When a table specifies a UserID column, require that user provider can produce an ID from the request info and append a clause specifying the ID to the query

• SQLite3
• MariaDB

Using reflection on each read seems like a waste when the proper type is already stored in the driver

Headers should have Content-Type: application/json

Tables should allow the programmer to specify the ID column and a function that generates new ID values for inserts. This will pave the way for inserting to tables with non-increment keys and returning last insert ID.

Bartlett such have a ProbeTables method that automatically populates the table list. Driver interface should also provide the same method that returns a slice of table names for consumption by Bartlett.

Should not overwrite tables that have already been provided.

Implment and and or query params to generate nested conditions

Generate UPDATE queries. Reject any requests sent without a WHERE.

Link a demo application in the readme

Part of providing a safe library is empirically validating the ability to handle garbage input. Throw a bunch of injection attempts at an actual website with sqlmap or similar tools.

Allow mounting routes with a prefix like /api instead of putting everything at /

Generate DELETE queries. Reject any queries sent without a WHERE.

Routes() should return []Route instead of []function, []string

Add CI tests instead of relying on local testing. Other projects have already figured out this sort of testing.

On inserts, check the incoming payload. If it's not an array, do a single insert and return the ID instead of the row count.

Error messages are currently sent to the log, but they should really go out to the client as well.

Allow users to specify the columns returned as in postgrest

Datetime fields can't be decoded to time.Time. Scan them into string instead.

Consider mimicking the Postgrest behavior

Generate LIMIT n and LIMIT m, n queries

Generate INSERT queries

• Test post handler in route.go
• Test IDColumn
• Test UserID

Allow requests to specify a single level of WHERE...AND conditions. Each condition should support a not. prefix for negation.

• eq
• neq
• gt
• gte
• lt
• lte
• like
• is
• in (including quoted strings)

Generate queries like ORDER BY col1 ASC, col2 DESC...

Test querying views to be sure that the column selection approach for each driver is not solely applicable to real tables

Allow users to select the output name used for their specified columns

Currently, a SQL error will cause a malformed result body with two JSON objects side by side, one for the error and another for the quantity of inserts.
Instead, collect all insert errors into an errors output array to go into the result object.

Implement a caching driver that wraps a normal database driver. Create a cache interface and implement cache backends. An in-memory backend will be the simplest. Lessons learned there will allow broadening the scope to supporting systems like Redis.

In the MariaDB driver, fields in the TEXT family are being inserted with blank values.

Establish a graph of foreign keys and allow JOIN queries against them. Consider taking the "record embedding" approach from Postgrest.