roundingwellos / backbone.eventrouter Goto Github PK

We'll need to flag and remove add route handlers from backbone history to do so.

  initialize() {. // add to the constructor
    this.cid = uniqueId('bber');
  },
  route() {. // add to the route function after the result of both `bbRoute.call(`s
    const route = EventRouter.prototype.route.apply(this, arguments);
    Backbone.history.handlers[0].cid = this.cid;
    return route;
  },
  destroy() {
    Backbone.history.handlers = reject(Backbone.history.handlers, { cid: this.cid });
    this.stopListening();
    this.trigger('destroy', this);
    return this;
  },

In the readme, an example is provided: myEventRouter.navigateFromEvent('some:event', 'foo');

however, looking at the code ( https://github.com/RoundingWellOS/backbone.eventrouter/blob/master/dist/backbone.eventrouter.js#L98 ) the API appears to be different.

Furthermore, the 'latest' version pulled from bower.io is 0.1.0 and doesn't include the method at all.

get off esperanto and older dev deps.

ie: /some/route/:param(/:optional)

http://backbonejs.org/#Router-routes

should this router even care?

  _isTriggeredFromRoute() {
    const currentRoute = this._getCurrentRouteTrigger();

    if (arguments.length !== currentRoute.length) {
      return false;
    }
-    return (arguments.length === union(arguments, this.currentRoute).length);
+    return (arguments.length === union(arguments, currentRoute).length);
  },

There is no this.currentRoute 🤦

It is breaking due to changes unrelated to us.

Code Climate breaking change:

See: https://github.com/jmeas/marionette.overlay-view/pull/5/files

http://backbonejs.org/#Router-extend

We should use classProperties such that instead of:

var myEventRouter = new Backbone.EventRouter();
myEventRouter.translateRoute(...);

it can just be:

Backbone.EventRouter.translateRoute(...)