Git Product home page Git Product logo

itemrack's People

Contributors

agandrup avatar apottere avatar blastehh avatar btnmasher avatar cyanokaze avatar davismj avatar inverimus avatar mikinho avatar minigwen avatar mrbuds avatar phatcat avatar plchampigny avatar pshurgal avatar road-block avatar rottenbeer avatar seidhrhealz avatar wardz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

itemrack's Issues

Unable to keybind to Mouse 3 through 5

In Slot Key Bindings, you are unable to bind to mouse 3 through 5, or alt/ctrl of those binds

This addon is amazing though, thank you so much for your hard work

"Any mount" does not always work

I found that using the mounted event and selecting "any mount," which is the default, would only work maybe 50% of the time. I changed it to my specific mount buff and so far it has worked every time.

Adding an option to change the number of rows/columns?

Alot of people i play with agree that it would pretty awesome to be able to customize the number of rows that pop up when you mouseover an itemslot. When using this for trinkets its kinda rough trying to find the right trinket when its a thin line of 15 trinkets (very easy to accidentally slide your mouse off the line and have to mouseover your trinket slot again.)

Great addon though, I didnt think of using this as a replacement for trinket menu (trinket menu hadnt been getting updated at all).

Stops working and have to log out and back in to fix

Date: 2019-10-06 04:14:26
ID: 1
Error occured in: AddOn: ItemRack
Count: 1
Message: Note: AddOn ItemRack attempted to call a protected function (UNKNOWN()) during combat lockdown.
Debug:
[C]: ?
[C]: ?
[C]: PickupInventoryItem()
ItemRack\ItemRackEquip.lua:267: MoveItem()
ItemRack\ItemRackEquip.lua:200: IterateSwapList()
ItemRack\ItemRackEquip.lua:145: LockChangedDuringSetSwap()
ItemRack\ItemRack.lua:696: func()
ItemRack\ItemRack.lua:786: OnUpdate()
[string ":OnUpdate"]:1:
[string "
:OnUpdate"]:1
Locals:
None
AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
AdiBags, vDEV
AdvancedInterfaceOptions, v1.3.3
AtlasLootClassic, vv1.2.2
AtlasLootClassicDungeonsAndRaids, vv1.2.2
AtlasLootClassicMaps, vv1.0.0
AucAdvanced, v8.2.6430 (SwimmingSeadragon)
AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
AucStatSimple, v8.2.6399 (SwimmingSeadragon)
AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
BeanCounter, v8.2.6422 (SwimmingSeadragon)
BlizzMove, v1.9
DBMCore, v1.13.13b
DBMDefaultSkin, v
DBMStatusBarTimers, v
Details, v
DetailsTinyThreat, v
ElvUI, v1.01
Enchantrix, v8.2.6428 (SwimmingSeadragon)
FieldGuide, vv1.5-release
FishingBuddy, v0.6 Beta 1
FiveSecondRule, v1.1
GrimoireKeeper, v1.1
GTFO, v4.50.1
Guidelime, v1.032
GuidelimeBusteas160leveling, v1.7.0-Release
GuidelimeSage, v1.0
HandyNotes, vv1.5.6
HandyNotesDungeonLocationsClassic, v1.03
HandyNotesFlightMastersClassic, v1.06
HandyNotesNPCsClassic, v1.16
HandyNotesTravelGuideClassic, vv2.1.4
IceHUD, v1.12.7
InFlightLoad, v1.13.003
Informant, v8.2.6374 (SwimmingSeadragon)
ItemRack, v
LeatrixMaps, v1.13.33
MissingTradeSkillsList, v1.13.18
MonkeyBuddy, v
MonkeyClock, vv3.2.0
MonkeyLibrary, v
MonkeyQuest, v
MonkeyQuestLog, v
MonkeySpeed, vv3.4.0
Necrosis, v5.0
NugComboBar, v1.13.3
NugEnergy, v1.13.10
OmniBar, vv10.3
OmniCC, v8.2.5
orbSellAndRepair, v1.0.1
Pawn, v2.3.7
QuestFrameFixer, v1.1.1
QuestIconDesaturation, v3.1
Questie, v4.1.1 BETA
SexyMap, vv3-classic
ShadowedUnitFrames, vv4.2-Classic-Beta7
SimpleDing, vv1.1.1
SlideBar, v8.2.6375 (SwimmingSeadragon)
SoulSpeak, v8.04-classic
SpeedyAutoLoot, v2.0.20
Spy, v1.0.9
Stubby, v8.2.6376 (SwimmingSeadragon)
TidyPlatesThreatPlates, v1.2.4
TinyTooltip, v8.2.1
TitanClassic, v1.1.1.11302
TitanClassicAmmo, v1.1.1.11302
TitanClassicBag, v1.1.1.11302
TitanClassicClock, v1.1.1.11302
TitanClassicGold, v1.1.1.11302
TitanClassicLocation, v1.1.1.11302
TitanClassicLootType, v1.1.1.11302
TitanClassicPerformance, v1.1.1.11302
TitanClassicRegen, v1.1.0.11302
TitanClassicRepair, v1.1.1.11302
TitanClassicVolume, v1.1.1.11302
TitanClassicXP, v1.1.1.11302
TomTom, vv11302-1.0.7
TradeSkillMaster, vv4.8.14
TradeSkillMasterAppHelper, vv4.0.5
VendorPrice, v1.2.9
WeakAuras, v2.15.2
WeaponSwingTimer, v4.1.0
WideQuestLog, v
BlizRuntimeLib_enUS v1.13.2.11302
(ck=a28)

Unable to change 2nd ring

I can't figure out what caused this. I had a set with all the gear I normally wear, and whenever I tried to change my 2nd ring it kept automatically re-equipping the old one even if I changed the set and reloaded the ui. I had to disable the addon to change it.

Missing trinkets

Some trinkets like Nifty stopwatch and Dimensional Ripper never shows up in hover menu.

No weapon swap when changing stances

Just wanted to leave the issue for you as requested. When setting weapons to change during a Warrior stance change, it doesn't seem to be working when in combat. Hoping you can get this fixed as I'd really like to use this addon in classic! Thanks!

ActionBar buttons disable and get the following error:

Date: 2019-10-10 20:28:05
ID: 1
Error occured in: Global
Count: ∞
Message: ..\AddOns\ItemRack\ItemRackEvents.lua line 242:
Attempt to register unknown event "ACTIVE_TALENT_GROUP_CHANGED"
Debug:
[C]: RegisterEvent()
ItemRack\ItemRackEvents.lua:242: RegisterEvents()
ItemRack\ItemRackEvents.lua:213: InitEvents()
ItemRack\ItemRack.lua:183: func()
ItemRack\ItemRack.lua:786: OnUpdate()
[string ":OnUpdate"]:1:
[string "
:OnUpdate"]:1
Locals:
(*temporary) = ItemRackEventProcessingFrame {
0 =
}
(*temporary) = "ACTIVE_TALENT_GROUP_CHANGED"

AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
ArkInventory, v30903
ArkInventoryRules, v20000
ArkInventoryRulesExample, v20000
ArkInventorySearch, v20000
Atlas, vv1.45.01.11302
AtlasClassicWoW, vv1.45.00.11302.05
AtlasLootClassic, vv1.2.3
AtlasLootClassicDungeonsAndRaids, vv1.2.3
AucAdvanced, v8.2.6430 (SwimmingSeadragon)
AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
AucStatSimple, v8.2.6399 (SwimmingSeadragon)
AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
BeanCounter, v8.2.6422 (SwimmingSeadragon)
DBMCore, v1.13.15
DBMDefaultSkin, v
DBMStatusBarTimers, v
Enchantrix, v8.2.6428 (SwimmingSeadragon)
Informant, v8.2.6374 (SwimmingSeadragon)
ItemRack, v
Questie, v4.1.2 BETA 121 dff5a12
SlideBar, v8.2.6375 (SwimmingSeadragon)
Stubby, v8.2.6376 (SwimmingSeadragon)
BlizRuntimeLib_enUS v1.13.2.11302
(ck=411)

might be me not sure

I made a set and then got a new item and went into the set to change out the head piece for the new item. It seems to save but when I use the set it puts the head piece on for 1 second and then switches back to the old headpiece.
edit
ok I found a setting called enable auto queues which is on by default and turning that off fixed it. I have no idea what autoqueues are.

No Bar where you can swap selected items

There is no bar that's movable where you can select an item to be able to swap it to other items. Sort of like the trinket menu one. cant seem to get that to show up not sure if its not in yet or what. Thank you so much for porting this much appreciated!

Error clicking on item in Trinket Queue

When I try to click on an item in the trinket queue, this error occurs and I'm unable to adjust the queue.

Date: 2019-09-19 10:44:38
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\ItemRackOptions\ItemRackOptions.lua line 1191:
   Usage: ItemRackOptItemStatsDelay:SetText("text")
Debug:
   [C]: SetText()
   ItemRackOptions\ItemRackOptions.lua:1191: ValidateSortButtons()
   ItemRackOptions\ItemRackOptions.lua:1159: SortListOnClick()
   [string "*:OnClick"]:1:
      [string "*:OnClick"]:1
Locals:
(*temporary) = ItemRackOptItemStatsDelay {
 0 = <userdata>
}
(*temporary) = false

Bank bag slot IDs go too high

There are only 6 bank bag slots in classic, but the addon seems to be expecting there to be 7; this is evident in ItemRack.lua, line 74, ItemRack.BankSlots. The list should include:
-1 (the main bank container)
5, 6, 7, 8, 9, 10 (the six bank bag slots)
NOT 11 (this doesn't exist in classic)
When 11 is in the list, it throws errors when trying to interact with the bank; with 11 removed, no errors.

Unable to change offhands in combat

Offhand will not switch will in combat and instead tries to queue and swap when out of combat. Encountered this issue after adding OH slot to UI via alt right click option. Manually tried changing OH items via this icon and a queue begins instead of an immediate swap.

Hard to see equipable items on right side of Character screen when wearing set

I noticed for example when I'm wearing an item set such as the Scarlet set piece for the belt, leggings, etc - it was difficult to see what items I could equip because the Tooltip was on top of the quick swap / list of items for that slot.

An alternative I thought about, is that for items on the right hand side instead of the list of items appearing to the right, what if it displayed to the left / inwards of the character screen?

I'm sure there's a few different ways to fix this, but eventually once you start to wear multiple pieces of Tier 1 and flip between them it could be a bit of an issue using that system to flip between them and just wanted to provide some feedback.

Appreciate you taking the time to fix this!

Cant see the bar

Hi,

For some reason, I cant see the bar in which you click to swap pieces quickly, like the trinketmenu bar. I use elvui, would you know if some addon is interfering with it?

ItemRack defining API functions

ItemRack is defining retail api functions in classic global namespace like:
GetSpecialization() and GetInspectSpecialization()
That is not acceptable, this behaviour is breaking another addons, like Clique or Details.

"One-handed" weapon WILL freeze slots midcombat

If you try to swap "one-handed" weapon to either main or offhand slots middle of combat, itemrack will grey out both slots and you need to unlock em manually with two-handed weapon or forced "mainhand" or "offhand" (eg shield)

Switching weapons in combat fails.

Using itemrack to swap weapons in combat fails because of a "protected function".

ID: 1
Error occured in: AddOn: ItemRack
Count: 1
Message: Note: AddOn ItemRack attempted to call a protected function (PickupContainerItem()) during combat lockdown.
Debug:
   [C]: PickupContainerItem()
   ItemRack\ItemRackEquip.lua:276: MoveItem()
   ItemRack\ItemRackEquip.lua:198: IterateSwapList()
   ItemRack\ItemRackEquip.lua:113: EquipSet()
   ItemRack\ItemRack.lua:1189:
      ItemRack\ItemRack.lua:1126
Locals:
None

In the brief digging I did PickupContainerItem() does not look to be protected but there are some docs about calling it twice in the same tick causing the client issues. See: https://wowwiki.fandom.com/wiki/API_PickupContainerItem

Broker?

Would be nice to see this on Titan Panel instead of the minimap

Tool Tips on saved items

is it possible for ItemRack classic to add Tooltips to gear items to show what set they belong to. worried about vending gear that i have saved in a set.

Events don't work properly

I tried to set up an "Event" where I equip a spirit staff for evocation then re-equip my previous MH+OH but it usually bugs out for me.

Toggle not toggling

I have two sets created on my warrior;

  • Shield
  • DualWield

Using the macro;

/itemrack toggle Shield, DualWield

When I first used ItemRack the other day, this macro worked just fine. Now when I use it, it will gladly put me in Shield, but will not swap back to DualWield. I don't get any error messages either, it just doesn't work... I can still manually swap to both armor sets via the minimap button as well.

Won't save

Maybe I'm not using it right. My experience has been with Outfitter which doesn't work in Classic.

When I change my character's equipment, it shows in itemrack, but the save button never enables. So I have a fishing outfit, and type in the set name Fish, but the save button stays grayed out, so I can never again reference that set of equipment with the pull down menu.

Auto-Mount doesn't automatically swap sometimes

Auto-Dismount seems bugged, works sometimes, doesn't work other times, sometimes only swaps half my items, sometimes constantly swaps my items over and over and over until I physically turn the addon off. Please fix, we need a working auto-swap addon in classic!

Drinking Event Bug

So I tried to make an Event that equips spirit gear when drinking but it constantly switching back and forth between the spirit gear and the regular gear, like, four times a second constantly.

Please fix this and equipping weapons in combat for Evocation. Ty

LUA error while trying to equip items from bank

Date: 2019-09-07 23:34:57
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\ItemRack\ItemRack.lua line 603:
ContainerIDToInventoryID(): invalid container ID
Debug:
[C]: ContainerIDToInventoryID()
ItemRack\ItemRack.lua:603: ValidBag()
ItemRack\ItemRack.lua:575: FindInBank()
ItemRack\ItemRack.lua:1921: GetBankedSet()
ItemRack\ItemRack.lua:1182:
ItemRack\ItemRack.lua:1126

ItemRack doesn't detect Ultra-Flash Shadow Reflector as a trinket

I've noticed for past few days at least that even if the Ultra-Flash Shadow Reflector is the only trinket in my bags, ItemRack doesn't suggest it when hovering over the trinket bar I've created.

Tried re-creating the trinket menu, disposing all my trinkets to bank etc, but it's the only trinket that doesn't seem to work.

rogue weapon swapping with stealth event

i want to use itemrack to automatically swap my dagger and sword when i stealth. it works beautifully when i stealth, my dagger goes to my MH as intended. however, after i backstab (or ambush, he's still a low level), it doesn't swap back. it DOES swap back after combat, but that defeats the purpose. can anyone help?

Addon doesn't work properly with a bank open

Hi, I wish that while interacting with a bank the addon would pick items from bank and stash currently equipped items in the same bank slots.

Currently I have to dump all my bank inventory into my bag, close the bank, equip through addon, and then stash everything back to the bank again, I have like 4 different sets of equipment so clicking all that gear back and forth takes a lot of time. Storing all that gear in my bags is not an option because while AoE grinding every inventory slot matters.

error with icons

2x [ADDON_ACTION_BLOCKED] AddOn 'ItemRack' tried to call the protected function 'SetBindingClick()'. !BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519> [C]: in function SetBindingClick'
ItemRack\ItemRack-3.23.nil.lua:1884: in function SetSetBindings' ItemRack\ItemRack-3.23.nil.lua:434: in function InitCore'
ItemRack\ItemRack-3.23.nil.lua:202: in function func' ItemRack\ItemRack-3.23.nil.lua:846: in function OnUpdate'
[string ":OnUpdate"]:1: in function <[string ":OnUpdate"]:1>

Locals:
InCombatSkipped`

https://i.imgur.com/QLi5X3n.png

After Cast spams chat

Hello,
I tried using After Cast event, but instead of perfoming the action,
it started spamming the lua code into chat (for which I was promptly silenced for).

Did I do something wrong, or is it a known bug?

local spell = "Gouge"
local set = "Dagger"
if arg1=="player" and arg2==spell then
  EquipSet(set)
end

--[[This event will equip "Name of set" when "Name of spell" has finished casting.  Change the names for your own use.]]

Mounted Gear Swap Back

It appears that the item swap back is bugged using the mounted event. I've tried setting it to the buff id as well as buff name instead of just any mount. The gear I had on previously does not reequip.

Bug when change stuff in combat

When i change my stuff with a macro IN COMBAT
like for exemple
/cast Posture défensive
/itemrack equip Def

My weapon is stuck (grey) and i can't change it anymore until i disconnect, i also have an error in chat
aaa

lua error

getting like 10 errors a second with current version

ItemRack attempted to call a protected function (PickupInventoryItem()) during combat lockdown

Date: 2019-09-17 13:37:06
ID: 1
Error occured in: AddOn: ItemRack
Count: 1
Message: Note: AddOn ItemRack attempted to call a protected function (PickupInventoryItem()) during combat lockdown.
Debug:
[C]: PickupInventoryItem()
ItemRack\ItemRackEquip.lua:278: MoveItem()
ItemRack\ItemRackEquip.lua:211: IterateSwapList()
ItemRack\ItemRackEquip.lua:113: EquipSet()
ItemRack\ItemRackEvents.lua:348: ProcessStanceEvent()
ItemRack\ItemRackEvents.lua:293: ProcessingFrameOnEvent()
[string ":OnEvent"]:1:
[string "
:OnEvent"]:1
[C]: CancelShapeshiftForm()
..\FrameXML\ChatFrame.lua:1251: ?()
..\FrameXML\ChatFrame.lua:4589:
..\FrameXML\ChatFrame.lua:4556
[C]: ChatEdit_ParseText()
..\FrameXML\ChatFrame.lua:4270:
..\FrameXML\ChatFrame.lua:4269
[C]: ChatEdit_SendText()
..\FrameXML\ChatFrame.lua:2699:
..\FrameXML\ChatFrame.lua:2692
[C]: ?
[C]: UseAction()
..\FrameXML\SecureTemplates.lua:338: handler()
..\FrameXML\SecureTemplates.lua:616:
..\FrameXML\SecureTemplates.lua:564
[C]: ?
..\FrameXML\SecureHandlers.lua:266:
..\FrameXML\SecureHandlers.lua:263
[C]: ?
..\FrameXML\SecureHandlers.lua:296:
..\FrameXML\SecureHandlers.lua:279
(tail call): ?
Locals:
None
AddOns:
Swatter, v8.2.6377 (SwimmingSeadragon)
AtlasLootClassic, vv1.1.11
Bartender4, v4.8.7
ClassicAuraDurations, v
ClassicCastbars, vv1.0.6
ClassicCastbarsOptions, v
DruidMana, v1.2
EasyFishingClassic, v1.2
GuildTooltip, v1.1.3
Inventorian, v1.13.2.4
ItemRack, v
ItemTooltipProfessionIcons, v1.1.1
LeatrixMaps, v1.13.30
LeatrixPlus, v1.13.30
MissingTradeSkillsList, v1.13.07
MonkeyLibrary, v
MonkeyQuest, v
MonkeyQuestLog, v
NugEnergy, v1.13.7
OmniCC, v8.2.4
Prat30, v3.7.36
Prat30Libraries, v
Quartz, v3.5.1
Questie, v4.0.18 BETA
QuestLogEx, v1.2
RealMobHealth, v2.11
Recount, vv1.13.2c
SlideBar, v8.2.6375 (SwimmingSeadragon)
Stubby, v8.2.6376 (SwimmingSeadragon)
TrinketMenu, v7.3.2
WeakAuras, v2.14.6
WhatsTraining, v1.8.4
BlizRuntimeLib_enUS v1.13.2.11302
(ck=33c)

found the item

I tryed to change gloves with some form my inv
Right cliked on item rack slot
Bags frozen

Item deleted without confirmatio

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.