Git Product home page Git Product logo

aws-sign4's Issues

Test fails on CCL

Disabling tests on CCL until this is fixed:
fd7e8ce

Current version in cl-travis is 1.10. The latest version of ironclad can't be loaded with this version of CCL. I get the following error message: Unknown X86 instruction (CCL::RETQ)

luismbo/cl-travis#20

GET requests and the payload parameter

In GET requests one must provide :payload "" in order to generate valid signatures. This is confusing and unnecessary.

This creates an invalid signature:
(aws-sign4:aws-sign4 :region :us-east-1
:service "route53"
:method :get
:host "route53.amazonaws.com"
:path "/2013-04-01/hostedzone")

This generates a valid signature:
(aws-sign4:aws-sign4 :region :us-east-1
:service "route53"
:method :get
:payload ""
:host "route53.amazonaws.com"
:path "/2013-04-01/hostedzone")

Behaviour when service is undefined

When the signing function is called with service bound to nil, the credential scope value features the string nil which should probably not happen.

The correct behaviour should be to either:

  • Signal an error, with a retry allowing to provide a service string.
  • Provide a sensible default string value for the service. This could be "service" as in AWS test suite for signv4, the empty string or a phony value "this-is-not-an-actual-service-name".

My personal preference goes to the first possibility. What do you think?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.