rosmaryfc / meme-ify-me-arhm Goto Github PK

when choose "demo" to edit, top right corner this is "setting" function by pressing the sign, but this "setting" seems useless. press it, but nothing happened.

The save button after editing a meme in both vanilla and demotivational modes does not work. I hope this doesn't demotivate progress :p

• When the user chooses to take a picture, the orientation of the image used throughout the app isn't always correct.

• In the Main Activity, the preview memes that appear as a toast when you select a radio button cover the Take Picture and Gallery buttons for the toast's duration.

After seeing other's demo, I thought it would be nice if we added the choice of fonts, font sizes, font colors and drag & drop features.

I think it'd be great if your app had a template option that gave users some of the most popular current photos used for memes and then let the user make a vanilla or demotivational meme from that photo. I am in process of adapting that functionality from my team's app to the pull request I made to your project, but I haven't finished it yet. :)

It's really awesome integrating the Editable Picture API but going through the app the amount of toasts can add up and i think it clutters up the UI and it can be distracting, especially if you want to make a quick meme. Maybe trying to reduce the amount of toast to just the most vital information would be a good idea. ^.^

I would say keep it for only the meme title, but get rid of the "settings" button since it doesn't do anything.

Would be cool to implement a random feature that lets you add random words of text to your chosen picture. Or if you want to go the full monty, use popular templates and randomize everything. That was my original plan but I did not have time to try and implement it.

Vanilla feature: user can edit words on top, middle and bottom. if I just wanna edit words on pic's top and bottom, but not in the middle (or any other ways, keep on top words, or any two choices). right now have to writes words in all of 3 lines then can save the pic.

-this would be a good feature to add to the app

The buttons look great! I think setting an image to the background will make the layout can look nicer.

The preview button must be clicked in order to update the picture so it is saved properly. Maybe it would be better to make sure the preview buttons are clicked at least once before the save button is enabled; that way the user understands the picture must be previewed before it is updated and saved.

• The Aspect Ratio of the images are not preserved in the preview Image for the memeActivities and in the final meme image.

open APP -- choose demo posters -- choose photo from gallery -- press "edit meme" -- then APP crush.
(the test phone I used is sumsung galaxy s3)

When making a vanilla meme, you guys have preview buttons that I'm suggesting be replaced by a textwatcher instead to help declutter the UI. You can see here what would need changing (from my pull request):

alizinha@983b733

Same thing with the demotivational meme. Here's my commit where I showed how that could be changed):

alizinha@0c63ced

Hi, I saw that you guys had log messages throughout your app but there were places where you'd want them and you didn't have them, so in this commit you can see where I added them:

alizinha@bd6a088