rose-pine / vscode Goto Github PK

What the heck is it and how can we take advantage of semantic highlighting?

Docs at https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide

When reload is required, the wrong text color is used in button foreground. May extend to other parts of UI.

Hey there,
I've got to say that I really enjoy the theme you've created!

So I've installed right away. I noticed though that React-based code is a bit harder to read compared to e.g. oceanic next.

Just curious whether this was an intentional design choice or something you weren't aware of.

Have a nice day and thanks for the pretty colors!
Daniel

Hi

Rose Pine theme:

Another theme:

I don't like italic text because it's hard for me to read it. It will be awesome to be able to change it like this:

Thanks

A user reported compatibility issues with bracket pair colorizer - colorized brackets no longer show up with the theme enabled. Having trouble replicating the issue with either colorizer v1 or v2 but will keep searching :)

With editor.linkedEditing: true, highlighting of the matching closing/opening tag i html/jsx doesn't work.

Enabled:

Disabled:

Hi.

VSCode, when editing minimized CSS that has an error, highlights all the content. This error highlight color is very similar to the search result highlight color so I always have to switch to another theme when doing a search.

Here is the screenshot:

It's very difficult to spot a result, especially on full screen and with short search keywords, like two or three characters, which are not repeating on the same viewport.

Thank you for this beautiful theme.

Cheers.

PR #48 resolves

Can you please provide your vscode settings it is very clean so that i can feel the vibes you were getting with these theme plz :)

The escape character constant does not have the correct token color due to a typo in"constant.charcter.escape". This affects all three themes.

This should be overlay, while bright black remains subtle text

multi select or single select a word, high light can more clearly?

it is few little different when choosing a word , the high light is not very contrast

I recently started using VSCode for Jupyter notebooks and realized that at present Rosé Pine's colors for cells and cell highlighting are barely legible. This is in both dark and light versions.

I've included screenshots of both, along with a screenshot of the Github Light theme for contrast of how legible and accessible the expectation would normally be.

I'm happy to toy with this if pointed in the right direction and submit a PR ☺️, not a huge deal to switch themes while working in Jupyter for the time being, but I of course think Rosé Pine is the greatest theme of all time and would love to help make it work for this use case.

First: Hello, this theme and the whole Rose-Pine palette are AWESOME! I need a little bit of time to get "used" to it but now I'm trying to use it (palette) everywhere I can.

I have tried to remove italics, I stole this settings from the Tokyo theme

"[Rosé Pine]": {
            "textMateRules": [
                {
                    "scope": [
                        "comment",
                        "meta.var.expr storage.type",
                        "keyword.control.flow",
                        "meta.directive.vue punctuation.separator.key-value.html",
                        "meta.directive.vue entity.other.attribute-name.html",
                        "tag.decorator.js entity.name.tag.js",
                        "tag.decorator.js punctuation.definition.tag.js",
                        "storage.modifier"
                    ],
                    "settings": {
                        "fontStyle": ""
                    }
                }
            ]
        }

but there is something italic here and there.

Could you provide a No Italics version too ?

Syntax highlighting in polyglot notebooks are broken after the November update.

This is how a snippet looks in the default theme

This is how a snippet looks with Rosé Pine

Jupyter notebooks using python seems to be working fine. This is just affecting polyglot notebooks with C#, F# and Powershell.

• Pref paths over paths-ignore for workflow
• Fix potential double version bump via github workflow + version script?
• Improve debug experience
  • Build themes on launch

Discussed in #43

So many different colors for = 🙃

Currently vue 3 script setup rfc is still experimental and relies on volar. Looking at the tokens provided by volar, this may not be possible to fix at the moment but leaving this here in case things improve.

After switching to Rosé Pine I noticed that I rely on glances at the scrollbar to know my position inside big files. I also use the scrollbar to know when I've reached a highlighted line of code - the small gray marks on the right.

It would really help if Rosé pine didn't hide the scrollbar!

Rose pine:

Expected:

Remove the contrast between the terminal and the rest of the editor. Or make it it's own theme.

Whats the font family at screenshot and file icon theme used?

Consider how the rest of theme components are blending in together seamlessly, the context menu dividers seem a bit standout.

I think it would be perfect if it isn't too noticeable.

This is Night Owl theme in comparison:

Hi, first congrats for creating this beautiful theme. I like that is available in my fav environments, programs etc.

Not sure if it's an issue but I think most people will tend to agree the source control tool looks distracting with all lines setting a border. It doesn't help to focus and makes the tool look messy.

Here is how it looks in most themes:

My proposal is to get rid of the border. The color for added blocks or deleted blocks is fine.

Hi,

I have some problems with the tokens in JavaScript. Specifically the this keyword and parameters aren't colorized.

Rose Pine Moon:

GitHub Dark:

Default:

Prettier should be applied after themes are generated for improved diffs between updates

Hi!

What is the background image in this display photo?

I'd love to sue as my background!

For the info, I use Remix framework, you can clone at epicweb-dev/full-stack-foundations

Waiting on microsoft/vscode#29091

Hello,

I love the theme, but I find myself barely able to make out the scrollbar when scrolling down. I've tested it on 3 different displays and it's way too hard to see, especially out of the corner of my eye. I think it would benefit from a darker/more contrasting color.

I'm new to Astro, and they recommend installing their extension to support .astro file. It also results in unsupported file icon in Rosé Pine theme.

I have also searched in their repo but don't know how VS Code extension work to change my preference, could we do it from our side?

https://github.com/withastro/language-tools/blob/main/packages/vscode/syntaxes/astro.tmLanguage.json

I guess we could include another file type (which is astro) to our specs
https://github.com/rose-pine/vscode/blob/main/icons/rose-pine-icon-theme.json

Please guide me if I can help.

Currently we use dawn colours for the file icon theme. In a recent update to VSCode, we can now use our dark variant palette in dark mode and dawn in light mode.

https://code.visualstudio.com/api/extension-guides/file-icon-theme#file-association

I have just bought a new LG 4K monitor, and notice an issue about the colors. At first I thought that Hyper canvas was making color washed out, then I opened the official website, turned out the palette in VSCode was warmer.

I have no idea how to fix this because when inspecting in VSCode Developer Tool, the colors have the same value :(

Hey,
I'm facing some compatibility issues with the extention RapidAPI Client.
Close your eyes it's hurting 😂

1. The name of active tabs is not displayed
2. The line number column is red

Rose Pine all 3 versions (standard, moon and dawn)

Monokai

Overview ruler should be themed by default - more items keep getting added to the theme api rendering this more of an annoyance.

Hi,

Great theme. Been using it for a while now!

I've found that when I use the extension Magit - https://github.com/kahole/edamagit, the diff view has no colors.
I have searched for a very long time trying to figure out exactly what setting Magit uses to color the diff views, but with no luck (no experience with creating themes).

Magit has colors in many other themes, e.g. "Field Lights", "Gruvbox" and the default theme of VSCode.
Palenight is also missing colors for the Magit view.

Hope someone can help or point me in a settings direction, so I can create the PR.

Rosé Pine Moon:

Field Lights:

When using VScode's Quickfix feature and there're no code actions available, the box is missing a background color.

Rosé Pine Moon:

Default theme:

helllooo! it's me again.

curious for your thoughts on something that throws me off pretty regularly even though i'm aware of it -- which is that the active tab looks (to me) like it's deactivated, and the non-active tabs, because they have the same color as the background of the editor, creating a sense of continued space, look active. Screenshots attached.

My proposal would be to flip these styles, so all the inactive tabs are dimmer and the active tab is the same color as the editor background.

happy to take a stab at it if that's a change you support.

We could add colors for a few popular extensions if they allow it

https://github.com/wayou/vscode-todo-highlight

I would love to see matching product icons bundled with the rest of the Rosé Pine theme!

Currently thinking about using Material Product Icons