Move rmw_implementation to the rmw repo about rclcpp HOT 12 CLOSED

It was a bad idea to move it into the rmw repository since that generates a circular repository dependency chain:

rmw_implementation (in rmw) -> rmw_opensplice_cpp (in rmw_opensplice) -> rwm (in rmw)

That was actually the reason why it was not in the rmw repo before.

from rclcpp.

from rclcpp.

For the same reason rosidl_default_generators should be moved out of the rosidl repo.

from rclcpp.

What's wrong with the dependency chain? Just that you can't easily get rmw without the rmw_implementation package?

from rclcpp.

Two repositories depending on each other is a not desired circular dependency. E.g. you will never be able to do a first-time release of any of the two.

from rclcpp.

Ok, I agree, then what should we do? As I see it we can either move rmw_implementation to a different existing repository or move it to its own repository.

I am leaning towards its own repository, but it would be nice to not have yet another repository to deal with.

from rclcpp.

I share your concern to keep the repo count low. But I don't think it fits well into any of the existing repos and therefore I also lean towards a new separate repo.

from rclcpp.

What should we call this repository? Just rmw_implementation?

from rclcpp.

I don't have a better suggestion and would therefore suggest to keep the name as-is.

from rclcpp.

The new repository is here: https://github.com/ros2/rmw_implementation

from rclcpp.

Ok, I've opened pull requests to address the move. Please review.

from rclcpp.

lgtm

from rclcpp.