Git Product home page Git Product logo

Comments (5)

dirk-thomas avatar dirk-thomas commented on August 24, 2024 1

what is the rationale to install executables in $base/lib and not in $base/bin?

Excutables which should not be on the global path (bin) should be placed into lib/<pkgname to be ros2 run-able.

from ci.

sloretz avatar sloretz commented on August 24, 2024 1

what is the rationale to install executables in $base/lib and not in $base/bin?

@ivanpauno I think our desire comes from wanting to allow ROS packages to not worry about name collisions of their binaries with other ROS packages. That's why it's $base/lib/<my pkg>/my_executable

Excutables which should not be on the global path (bin) should be placed into lib/<pkgname to be ros2 run-able.

I remember this was justified by saying the binaries are not meant to be executed by the user directly (which they're not, they're executed by ros2 run), so they can be put into $base/lib/<pkg name> because that reason is acceptable in the FSH. Re-reading it, it looks like we got it a little bit wrong. $base/lib/<pkg> is incorrect. $base/usr/lib/<pkg> would be ok, but best of all we should actually be putting them into $base/usr/libexec/<pkg>.

  1. We could make a case upstream that there should either be a way to opt-in to installation directory options in a virtual environment and provide patches to that end.

My reason for bringing the FSH up, can we make the case to upstream that we need the install options in a virtualenv to comply with the FSH for executables not meant to be executed by user's directly? I wonder if that justification would carry more weight than our own reasoning of wanting to avoid name collisions.

from ci.

ivanpauno avatar ivanpauno commented on August 24, 2024

what is the rationale to install executables in $base/lib and not in $base/bin?

If we want to still install executables in $base/lib, I think that options 2 or 3 are the best solutions.

from ci.

cottsay avatar cottsay commented on August 24, 2024

I've attempted possible solution (3) in this PR: colcon/colcon-core#530

from ci.

man-martin avatar man-martin commented on August 24, 2024

Is this still a work in progress? We used the old virtualenv version as a workaround as well but we are migrating to Debian 12 bookworm. Virtualenv 16.7.9 does not create a valid virtual environment anymore on this debian version.

Is there another workaround? The current version of colcon installed via pip in a virtual environment still ignores setup.cfg when building humble from source.

from ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.