Git Product home page Git Product logo

Comments (12)

wjwwood avatar wjwwood commented on July 30, 2024

I'm not sure this should be fixed here. I think PCL should depend on them.

from perception_pcl.

LucidOne avatar LucidOne commented on July 30, 2024

@trainman419 did you open an issue on this against PCL?
Is PCL reasonably usable without these packages?

from perception_pcl.

trainman419 avatar trainman419 commented on July 30, 2024

I believe PCL is usable without this. I have not filed a bug upstream.

from perception_pcl.

LucidOne avatar LucidOne commented on July 30, 2024

If PCL is usable without these packages, I am OK with perception_pcl depending on these packages.

This will probably get fixed in the next release.

from perception_pcl.

mikeferguson avatar mikeferguson commented on July 30, 2024

+1 to this getting fixed somewhere. If for some reason we aren't going to fix the dependencies, we should at least list this on the Indigo migration page, so people can easily figure out what to install to make their life in cmake not suck.

from perception_pcl.

DLu avatar DLu commented on July 30, 2024

+1

from perception_pcl.

paulbovbel avatar paulbovbel commented on July 30, 2024

So the consensus is, there needs to be a build dependency on python-vtk and libvtk-java?

I will update the indigo branch sometime soon, if someone has this already setup on their machine, please feel free to submit a pull request.

from perception_pcl.

wjwwood avatar wjwwood commented on July 30, 2024

@paulbovbel this is going to be an issue on Ubuntu xenial and perhaps wily (I haven't checked though).

Currently our rosdep rule for python-vtk resolves to python-vtk in xenial, but the libpcl-dev package in xenial depends on libvtk6-dev (http://packages.ubuntu.com/xenial/libpcl-dev) which in turn depends on python-vtk6 (http://packages.ubuntu.com/xenial/libvtk6-dev). This causes a loop where every time you run rosdep install ... it will uninstall python-vtk and then install python-vtk6 and then the next time you run it will do the opposite.

I think we should probably create a Kinetic branch for this package and remove the dependency on explicit dependency on python-vtk since libpcl-dev appears to have it now.

from perception_pcl.

tfoote avatar tfoote commented on July 30, 2024

@wjwwood that will only solve it for this package. Any package that asks for python-vtk and libpcl-dev will run into this problem. We should probably consider changing to python-vtk6 to be compatible. What is the level of API change between plain and version 6?

from perception_pcl.

wjwwood avatar wjwwood commented on July 30, 2024

@tfoote based on this thread, the dependency was introduced here just because it was missing in the pcl binary, which no longer seems to be the case. So we could remove the dependency here, remove the wily and xenial entries for the key and recommend anyone else who tries to use to instead move to a new key called python-vtk6 which can be created as needed.

from perception_pcl.

tfoote avatar tfoote commented on July 30, 2024

I created a ticket to track this in an open state ros/rosdistro#10752 lets move the discussion there.

from perception_pcl.

paulbovbel avatar paulbovbel commented on July 30, 2024

@wjwwood thanks, removing python-vtk for kinetic-devel

from perception_pcl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.