roout / chatterfinity Goto Github PK

Cache the data (realm id, realm status) acquired from the blizzard server.
Then chain functions used to request these data.

Print the arena rating by provided username from TBC WOW

A code fragment below will lead to problem: an internal outgoing buffer will be overwritten. To fix this issue buffer can't be touched before the whole message had been sent. Use special buffer.

IrcConnection * irc = ...;
irc->Write("Send some text");
irc->Write("Send some more text");
irc->Write("Send another one");

Blizzard service should save access token between sessions. It's not required to request a new token for each new session.

Prevent frequent requests for commands. Imagine, several !arena commands being invoked! If the result hasn't been cached yet, a lot of arena http connections will be born with heavy incoming payloads (around 9 MB)...

Add connection state to prevent invoking Connection::Connect(...) on the already connected one. It's especially needed for IrcConnection which has Login command

• introduce aliases for info, error, warn levels
• maybe it will make more sense to log into one file? IDK
• log more stuff
• maybe use FUNCTION macros

Must have 1s delay (more if it's slow mode) between messages to the same channel
Reference

Enable an application to handle transient failures when it tries to connect to a service or network resource, by transparently retrying a failed operation. This will improve the stability of the application.

Retry pattern

Steps to reproduce:

1. Login & join channel 'X'
2. Write within chat from the another account or from the same (shouldn't matter) the command:
   ! <anything>
   with space between ! and the next word.
3. Write within chat any valid command (for now it's realm-status):
   !realm-status

Result:
Console logs shows that the status was extracted successfully but response failed to appear in channel chat
Expected result:
Message in char with status of the flamefor server

In connection logs --error: SSL stream shutdown: stream truncated may not be an error because now I'm not ready to handle keep-alive connections. So the stream is will be truncated when connection is closed.

Connection callback onWrite will be ignored when more than one message is queued for writting; only callback for the last message from buffer will be called

They handle callback (onReadSuccess) differently:
IrcConnection continue to read and doesn't update callback if it's empty object (on repeated IrcConnection::Read() call) whereas HttpConnection always updates the callback (even if it's empty)

Closed is being called twice (two error messages about ssl underlying socket shutdown) for irc connection

Twitch Dev Forum about this issue.
Twitch IRC Capabilities

Encounter a problem here: #17

Create log files (Connection_[\d+].txt) for only failed connections (save log to buffer and dump it to file only on error)