roots / sage-installer Goto Github PK

View Code? Open in Web Editor NEW

30.0 12.0 81.0 102 KB

Sage 9 installer

Home Page: https://github.com/roots/sage

License: MIT License

PHP 63.36% JavaScript 6.68% SCSS 29.96%

sage-installer's Introduction

Sage Installer

This repository contains the installation scripts for the Sage starter theme.

Contributing

Contributions are welcome from everyone. We have contributing guidelines to help you get started.

Community

Keep track of development and community news.

Participate on the Roots Discourse
Follow @rootswp on Twitter
Read and subscribe to the Roots Blog
Subscribe to the Roots Newsletter
Listen to the Roots Radio podcast

sage-installer's People

Contributors

Stargazers

Watchers

sage-installer's Issues

Composer Installation on Windows

Ok, so following @QWp6t 's suggestion, I've posted the issue here.

Trying the composer installation on Windows 10.1 is resulting in an error.

I followed the installation instructions on the Github repo composer create-project roots/sage your-theme-name dev-master.

After the composer installation failed, doing sage meta and sage config, as suggested, results in exceptions being thrown, and sage preset prolly cannot run since the setup is not finished yet.

Windows 10.1
PHP 7.1.7
Node 7.6.0
NPM 4.1.2
Local build.

E:\Trabalho\ShirkitTheme>composer create-project roots/sage sage-master dev-master
Installing roots/sage (dev-master 8691074b29c4c09dae40f0f0c33dc2b51d9292e2)
  - Installing roots/sage (dev-master master): Cloning master from cache
Created project in sage-master
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 26 installs, 0 updates, 0 removals
  - Installing composer/installers (v1.3.0): Loading from cache
  - Installing paragonie/random_compat (v2.0.10): Loading from cache
  - Installing illuminate/contracts (v5.4.27): Loading from cache
  - Installing doctrine/inflector (v1.1.0): Loading from cache
  - Installing illuminate/support (v5.4.27): Loading from cache
  - Installing illuminate/container (v5.4.27): Loading from cache
  - Installing illuminate/events (v5.4.27): Loading from cache
  - Installing psr/log (1.0.2): Loading from cache
  - Installing symfony/debug (v3.3.4): Loading from cache
  - Installing symfony/finder (v3.3.4): Loading from cache
  - Installing illuminate/filesystem (v5.4.27): Loading from cache
  - Installing illuminate/view (v5.4.27): Loading from cache
  - Installing illuminate/config (v5.4.27): Loading from cache
  - Installing roots/sage-lib (9.0.0-beta.3): Loading from cache
  - Installing symfony/yaml (v3.3.4): Loading from cache
  - Installing hassankhan/config (0.10.0): Loading from cache
  - Installing brain/hierarchy (2.3.0): Loading from cache
  - Installing soberwp/controller (dev-master e9358ff): Cloning e9358ff900 from cache
  - Installing symfony/polyfill-mbstring (v1.4.0): Loading from cache
  - Installing symfony/translation (v3.3.4): Loading from cache
  - Installing nesbot/carbon (1.22.1): Loading from cache
  - Installing symfony/process (v3.3.4): Loading from cache
  - Installing symfony/console (v3.3.4): Loading from cache
  - Installing illuminate/console (v5.4.27): Loading from cache
  - Installing roots/sage-installer (1.1.0): Loading from cache
  - Installing squizlabs/php_codesniffer (2.9.1): Loading from cache
paragonie/random_compat suggests installing ext-libsodium (Provides a modern crypto API that can be used to generate random bytes.)
illuminate/support suggests installing symfony/var-dumper (Required to use the dd function (~3.2).)
illuminate/filesystem suggests installing league/flysystem (Required to use the Flysystem local and FTP drivers (~1.0).)
illuminate/filesystem suggests installing league/flysystem-aws-s3-v3 (Required to use the Flysystem S3 driver (~1.0).)
illuminate/filesystem suggests installing league/flysystem-rackspace (Required to use the Flysystem Rackspace driver (~1.0).)
symfony/translation suggests installing symfony/config ()
symfony/console suggests installing symfony/event-dispatcher ()
symfony/console suggests installing symfony/filesystem ()
illuminate/console suggests installing guzzlehttp/guzzle (Required to use the ping methods on schedules (~6.0).)
illuminate/console suggests installing mtdowling/cron-expression (Required to use scheduling component (~1.0).)
Generating autoload files
Do you want to remove the existing VCS (.git, .svn..) history? [Y,n]? Y
> Roots\Sage\Installer\ComposerScript::postCreateProject
Script Roots\Sage\Installer\ComposerScript::postCreateProject handling the post-create-project-cmd event terminated with an exception


  [Symfony\Component\Process\Exception\RuntimeException]
  TTY mode is not supported on Windows platform.


create-project [-s|--stability STABILITY] [--prefer-source] [--prefer-dist] [--repository REPOSITORY] [--repository-url REPOSITORY-URL] [--dev] [--no-dev] [--no-custom-installers] [--no-scripts] [--no-progress] [--no-secure-http] [--keep-vcs] [--no-install] [--ignore-platform-reqs] [--] [<package>] [<directory>] [<version>]


E:\Trabalho\ShirkitTheme>cd vendor
The system cannot find the path specified.

E:\Trabalho\ShirkitTheme>dir
 Volume in drive E is Dados
 Volume Serial Number is 04F5-6681

 Directory of E:\Trabalho\ShirkitTheme

03/08/2017  00:58    <DIR>          .
03/08/2017  00:58    <DIR>          ..
28/07/2017  16:25    <DIR>          bones-master
31/07/2017  00:04    <DIR>          node_modules
03/08/2017  00:58    <DIR>          sage-master
30/07/2017  00:54    <DIR>          xampp
               0 File(s)              0 bytes
               6 Dir(s)  84.271.640.576 bytes free

E:\Trabalho\ShirkitTheme>cd sage-master

E:\Trabalho\ShirkitTheme\sage-master>dir
 Volume in drive E is Dados
 Volume Serial Number is 04F5-6681

 Directory of E:\Trabalho\ShirkitTheme\sage-master

03/08/2017  00:58    <DIR>          .
03/08/2017  00:58    <DIR>          ..
03/08/2017  00:58               251 .editorconfig
03/08/2017  00:58                83 .gitattributes
03/08/2017  00:58    <DIR>          .github
03/08/2017  00:58               267 .gitignore
03/08/2017  00:58               814 .travis.yml
03/08/2017  00:58    <DIR>          app
03/08/2017  00:58            29.793 CHANGELOG.md
03/08/2017  00:58             1.196 composer.json
03/08/2017  00:58            53.273 composer.lock
03/08/2017  00:58    <DIR>          config
03/08/2017  00:58             1.087 LICENSE.md
03/08/2017  00:58           356.029 package-lock.json
03/08/2017  00:58             3.728 package.json
03/08/2017  00:58             2.310 phpcs.xml
03/08/2017  00:58             5.964 README.md
03/08/2017  00:58    <DIR>          resources
03/08/2017  00:58    <DIR>          vendor
03/08/2017  00:58           241.171 yarn.lock
              13 File(s)        695.966 bytes
               7 Dir(s)  84.271.640.576 bytes free

E:\Trabalho\ShirkitTheme\sage-master>cd vendor

E:\Trabalho\ShirkitTheme\sage-master\vendor>cd bin

E:\Trabalho\ShirkitTheme\sage-master\vendor\bin>dir
 Volume in drive E is Dados
 Volume Serial Number is 04F5-6681

 Directory of E:\Trabalho\ShirkitTheme\sage-master\vendor\bin

03/08/2017  00:58    <DIR>          .
03/08/2017  00:58    <DIR>          ..
03/08/2017  00:58               620 phpcbf
03/08/2017  00:58               134 phpcbf.bat
03/08/2017  00:58               619 phpcs
03/08/2017  00:58               133 phpcs.bat
03/08/2017  00:58               609 sage
03/08/2017  00:58               123 sage.bat
               6 File(s)          2.238 bytes
               2 Dir(s)  84.271.640.576 bytes free

E:\Trabalho\ShirkitTheme\sage-master\vendor\bin>sage.bat meta
PHP Warning:  file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/style.css): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Transformations\ThemeHeaders.php on line 30

Warning: file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/style.css): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Transformations\ThemeHeaders.php on line 30
PHP Warning:  file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/assets/config.json): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console\Commands\ConfigCommand.php on line 26

Warning: file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/assets/config.json): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console\Commands\ConfigCommand.php on line 26

  Roots\Sage\Installer\Console\Exceptions\ConfigureCommandException: FILE NOT
  FOUND:

      E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/style.css in
  E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console</>
  Commands\MetaCommand.php:37

  Stack trace:

  #0
  E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console</>
  Commands\Command.php(42):
  Roots\Sage\Installer\Console\Commands\MetaCommand->validate()

  #1
  E:\Trabalho\ShirkitTheme\sage-master\vendor\symfony\console\Application.php(8
  69):
  Roots\Sage\Installer\Console\Commands\Command->run(Object(Symfony\Component\C
  onsole\Input\ArgvInput),
  Object(Roots\Sage\Installer\Console\Style\RootsStyle))

  #2
  E:\Trabalho\ShirkitTheme\sage-master\vendor\symfony\console\Application.php(2
  23):
  Symfony\Component\Console\Application->doRunCommand(Object(Roots\Sage\Install
  er\Console\Commands\MetaCommand),
  Object(Symfony\Component\Console\Input\ArgvInput),
  Object(Roots\Sage\Installer\Console\Style\RootsStyle))

  #3
  E:\Trabalho\ShirkitTheme\sage-master\vendor\symfony\console\Application.php(1
  30):
  Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console
  \Input\ArgvInput), Object(Roots\Sage\Installer\Console\Style\RootsStyle))

  #4
  E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Applicat
  ion.php(23):
  Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\I
  nput\ArgvInput), Object(Roots\Sage\Installer\Console\Style\RootsStyle))

  #5
  E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\bin\sage(8):
  Roots\Sage\Installer\Application->run()

  #6 {main}


E:\Trabalho\ShirkitTheme\sage-master\vendor\bin>sage.bat config
PHP Warning:  file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/style.css): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Transformations\ThemeHeaders.php on line 30

Warning: file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/style.css): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Transformations\ThemeHeaders.php on line 30
PHP Warning:  file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/assets/config.json): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console\Commands\ConfigCommand.php on line 26

Warning: file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/assets/config.json): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console\Commands\ConfigCommand.php on line 26

  Roots\Sage\Installer\Console\Exceptions\ConfigureCommandException: FILE NOT
  FOUND:


  E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/assets/config.json
  in
  E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console</>
  Commands\ConfigCommand.php:48

  Stack trace:

  #0
  E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console</>
  Commands\Command.php(42):
  Roots\Sage\Installer\Console\Commands\ConfigCommand->validate()

  #1
  E:\Trabalho\ShirkitTheme\sage-master\vendor\symfony\console\Application.php(8
  69):
  Roots\Sage\Installer\Console\Commands\Command->run(Object(Symfony\Component\C
  onsole\Input\ArgvInput),
  Object(Roots\Sage\Installer\Console\Style\RootsStyle))

  #2
  E:\Trabalho\ShirkitTheme\sage-master\vendor\symfony\console\Application.php(2
  23):
  Symfony\Component\Console\Application->doRunCommand(Object(Roots\Sage\Install
  er\Console\Commands\ConfigCommand),
  Object(Symfony\Component\Console\Input\ArgvInput),
  Object(Roots\Sage\Installer\Console\Style\RootsStyle))

  #3
  E:\Trabalho\ShirkitTheme\sage-master\vendor\symfony\console\Application.php(1
  30):
  Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console
  \Input\ArgvInput), Object(Roots\Sage\Installer\Console\Style\RootsStyle))

  #4
  E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Applicat
  ion.php(23):
  Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\I
  nput\ArgvInput), Object(Roots\Sage\Installer\Console\Style\RootsStyle))

  #5
  E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\bin\sage(8):
  Roots\Sage\Installer\Application->run()

  #6 {main}


E:\Trabalho\ShirkitTheme\sage-master\vendor\bin>sage.bat preset
PHP Warning:  file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/style.css): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Transformations\ThemeHeaders.php on line 30

Warning: file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/style.css): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Transformations\ThemeHeaders.php on line 30
PHP Warning:  file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/assets/config.json): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console\Commands\ConfigCommand.php on line 26

Warning: file_get_contents(E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/assets/config.json): failed to open stream: No such file or directory in E:\Trabalho\ShirkitTheme\sage-master\vendor\roots\sage-installer\src\Console\Commands\ConfigCommand.php on line 26

 Which framework would you like to load? [Bootstrap]:
  [0] None
  [1] Bootstrap
  [2] Bulma
  [3] Foundation
  [4] Tachyons
 > 3

 Do you want to install Font Awesome? (yes/no) [no]:
 > yes



  [InvalidArgumentException]
  The "E:\Trabalho\ShirkitTheme\sage-master\vendor\bin/resources/assets" dire
  ctory does not exist.


preset [-Y|--overwrite] [-F|--fontawesome] [--] <framework>


E:\Trabalho\ShirkitTheme\sage-master\vendor\bin>

Illuminate/Support composer suggestion for symfony/var-dumper

After installing project dependancies, I noticed this suggestion.

illuminate/support suggests installing symfony/var-dumper (Required to use the dd function (~3.2).)

I work with Laravel and the dd( $variable ) function is pretty cool for debugging. It 'dumps and dies', which is basically another way of doing:

var_dump($variable);
die;

It is also better than var_dump, in that it pretty prints variables, arrays, and objects. In the case of objects, they come in the form of collapsible trees that you can expand and collapse. Great for json, collections, etc.

Also, in Illuminate/Support 5.5 they added other goodies such as dump(), which dumps the variable inline and continues.

Material Design Lite option

I do wish you had an option for Material Design Lite as s CSS framework. Would save a lot of time, and it's arguably more popular than some that are currently available. Cheers.

via https://www.facebook.com/groups/advancedwp/permalink/1766833473378859/?comment_id=1766938696701670&comment_tracking=%7B%22tn%22%3A%22R%22%7D

Sage color needs updating

A change was made in roots/sage#2055 that the preset stubs here have not adopted, and therefore they overwrite the new color with the old one.

postCreateProject: Show warning/more info about local dev

 Local development URL of WP site [http://example.dev]:
 >

 Path to theme directory (e.g., /wp-content/themes/sage) [/app/themes/sage]:
 >

at this point we need to iterate the importance of these values — if entered incorrectly then local dev will be broken

this could just be a link to something in the sage 9 docs

React and Vue presets

The addition of webpack.config.preset.js (roots/sage#2083 and roots/sage#2084) opens up a lot of opportunity for adding JS presets such as React and Vue since we have an easier way to override the base Webpack configuration. I know the current plan is to move to Laravel Mix, but for the interim, we could very easily provide these through the installer. These presets would need to be separate from the CSS presets since users would most likely mix and match them.

Thoughts?

Laravel Mix

Really liking how sage-installer looks so far. Also +1 for adding Bulma.

Following up from sage Issue #1868.

My comment on the issue seen here gives exaggerated defaults that work with Sage that can most definitely be simplified.

Would like to see an option for Laravel Mix implemented. :)

Thanks in advance.

postCreateProject interactivity on Windows platform non-existent

TTY mode not supported on Windows. Any way around that? The message that "some interactive parts might be skipped" is an understatement, they are all skipped. 👎

symfony/translation suggests installing symfony/config ()
symfony/console suggests installing symfony/event-dispatcher ()
symfony/console suggests installing symfony/filesystem ()
illuminate/console suggests installing guzzlehttp/guzzle (Required to use the ping methods on schedules (~6
.0).)
illuminate/console suggests installing mtdowling/cron-expression (Required to use scheduling component (~1.
0).)
Generating autoload files
> Roots\Sage\Installer\ComposerScript::postCreateProject
TTY mode is not supported on Windows platform.

Some interactive parts of post-create-project routine might be skipped.

Running the sage cli tool manually should still work.

PHP cURL extension missing as required dependency

I've read the guidelines for Contributing to Roots Projects
This request isn't a duplicate of an existing issue
I've read the docs and followed them (if applicable)
This is not a personal support request that should be posted on the Roots Discourse community

Description

The curl PHP extension is missing from the required dependencies, hence when the curl PHP extension is not available (like Ubuntu 20 with base PHP 7.4 package installed), a fatal PHP exception is caused when symfony/console is used:

PHP Fatal error:  Uncaught Error: Call to undefined function Roots\Sage\Installer\Console\Commands\curl_init() in /home/build/src/test/sage/vendor/roots/sage-installer/src/Console/Commands/PresetCommand.php:72
Stack trace:
#0 /home/build/src/test/sage/vendor/symfony/console/Command/Command.php(255): Roots\Sage\Installer\Console\Commands\PresetCommand->execute()
#1 /home/build/src/test/sage/vendor/illuminate/console/Command.php(166): Symfony\Component\Console\Command\Command->run()
#2 /home/build/src/test/sage/vendor/roots/sage-installer/src/Console/Commands/Command.php(47): Illuminate\Console\Command->run()
#3 /home/build/src/test/sage/vendor/symfony/console/Application.php(1009): Roots\Sage\Installer\Console\Commands\Command->run()
#4 /home/build/src/test/sage/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand()
#5 /home/build/src/test/sage/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun()
#6 /home/build/src/test/sage/vendor/roots/sage-ins in /home/build/src/test/sage/vendor/roots/sage-installer/src/Console/Commands/PresetCommand.php on line 72

Steps to reproduce

Use a system that has no PHP cURL extension yet installed/activated, e.g. an Ubuntu 20 system with PHP base package, but not the php7.4-curl package.
Install the symfony/console package (can be any version at time of writing as the latest version doesn't require the PHP cURL extension) using composer.
Use symfony/console,

Expected behavior:
The PHP cURL extension should be required, composer should stop installing and list it as required PHP extension (as it already does with PHP extensions).

Alternative/additionally the code should check for the presence of the curl_init function and throw an appropriate exception (PHP cURL extension is missing.).

Actual behavior:
composer deems the dependencies for this package satisfied and the installation as successful.
Using the package results in a PHP exception.

Reproduces how often:
As long as the PHP cURL extension is missing the error will occur.

Versions

Latest Sage 9.x.

Additional information

Similarissue with Sage 10.x that uses roots/acorn as it also uses curl but without requiring the curl binary or checking for its presence/availability on the PHP installation.

Prompt for user to open the theme folder before running yarn

Once install is complete you get the following prompt...

Please run yarn && yarn build to compile your fresh scaffolding.

...and I blindly run that almost every time and get an error. Consider perhaps..

Please run cd your-theme-directory && yarn && yarn build to compile your fresh scaffolding.

...or similar, for people like me ¯_(ツ)_/¯

Failures during installation, but still installs

Not sure if this is an issue with my connection, GitHub, Windows 7, or a combination of all three. There are three fatal errors during the installation, but then it magically creates the project.

First error is a failure to clone via SSH
Second is a bug " initial ref transaction called with existing refs"
Third is for permissions and access rights (weird one)

> create-project roots/sage Sage954 dev-master

Installing roots/sage (dev-master b4421be2696bd6021a11eb6893bb6fbb8a949d15)
  - Installing roots/sage (dev-master master) Cloning master from cache
    Failed to download roots/sage from source: Failed to clone https://github.com/roots/sage.git via https,
 ssh protocols, aborting.

- https://github.com/roots/sage.git
  Cloning into 'C:\xampp\htdocs\sites\webstractions\wp\wp-content\themes\Sage954'...
  fatal: BUG: initial ref transaction called with existing refs

- [email protected]:roots/sage.git
  Cloning into 'C:\xampp\htdocs\sites\webstractions\wp\wp-content\themes\Sage954'...
  Permission denied (publickey).
  fatal: Could not read from remote repository.

  Please make sure you have the correct access rights
  and the repository exists.

    Now trying to download from dist
  - Installing roots/sage (dev-master master) Downloading: 100%
Created project in Sage954
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 26 installs, 0 updates, 0 removals
  - Installing composer/installers (v1.4.0) Loading from cache
  - Installing paragonie/random_compat (v2.0.10) Loading from cache
  - Installing illuminate/contracts (v5.4.27) Loading from cache
  - Installing doctrine/inflector (v1.2.0) Loading from cache
  - Installing illuminate/support (v5.4.27) Loading from cache

There is another issue for post-install, but I will create a separate issue for that.

stats.roots.io not found/down

I've read the guidelines for Contributing to Roots Projects
This request isn't a duplicate of an existing issue
I've read the docs and followed them (if applicable)
This is not a personal support request that should be posted on the Roots Discourse community

Description

https://stats.roots.io/i is used for sending OS/framework statistics (when allowed by the developer).
The subdomain doesn't exist anymore, hence stat information cannot be received anymore.
https://github.com/roots/sage-installer/blob/master/src/Console/Commands/PresetCommand.php#L71-L77

Steps to reproduce

Try to request https://stats.roots.io/i (as used in the source of sage-installer).
Note that the subdomain can't be resolved, and the requests fails.

Expected behavior:
Subdomain should work and requests to it, too.

Actual behavior:
Subdomain doesn't exist anymore and requests to it don't work.

Reproduces how often:
Always.

Versions

sage-installer 1.6.4 (as used by Sage 9.x)

Add OpenCollective message after project creation

👉 https://opencollective.com/sage

Tailwind CSS Preset

I started working on a PR for this functionality, but ran into a couple issues I'd like to ask about before going further, since I'm not sure it fits in to the build process as easily as other presets. Here are a few issues I ran into:

Ideally, Tailwind should be included in two different lines, so you can add / extract components before/after the main bulk of the framework to avoid CSS specificity issues. This means main.scss has to be modified, which seems like a bit of an anti pattern, since a copy of sorts would have to be maintained in this installer repo.
Tailwind is configured via a javascript file, which is generated with a node command. I'm not sure any of the other presets do this?
Tailwind uses PostCSS, and it doesn't seem like any of the other presets do this either. This requires adding a line to webpack.config.js like tailwindcss: './tailwind.js'. Additionally, this causes some stylelinter errors too, and the tailwind-specific at-rules (i.e. @tailwind) need to be added to the excludes array for stylelinter in package.json.

Given the above problems, would Tailwind CSS still be considered as a preset? I'm happy to keep working on it if so, but otherwise a short guide or docs piece might be more appropriate when sage v9 is fully released. Thanks!

Add option to move required theme files to theme root folder

See: roots/sage#1938

postCreateProject not executing

After running a fresh install of Sage with composer create-project roots/sage project dev-master, the postCreateProject interactive portion of the install process fails to execute anything.

Here's my output:

troymcginnis@Troys-MacBook-Pro:themes$ composer create-project roots/sage project dev-master
Installing roots/sage (dev-master de27307b820305302fe2c5defd4bbee4e02a1dc3)
  - Installing roots/sage (dev-master master)
    Cloning master

Created project in project
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
  - Installing composer/installers (v1.4.0)
    Loading from cache

  - Installing paragonie/random_compat (v2.0.10)
    Loading from cache

  - Installing illuminate/contracts (v5.4.27)
    Loading from cache

  - Installing doctrine/inflector (v1.2.0)
    Loading from cache

  - Installing illuminate/support (v5.4.27)
    Loading from cache

  - Installing illuminate/container (v5.4.27)
    Loading from cache

  - Installing illuminate/events (v5.4.27)
    Loading from cache

  - Installing psr/log (1.0.2)
    Loading from cache

  - Installing symfony/debug (v3.3.6)
    Loading from cache

  - Installing symfony/finder (v3.3.6)
    Loading from cache

  - Installing illuminate/filesystem (v5.4.27)
    Loading from cache

  - Installing illuminate/view (v5.4.27)
    Loading from cache

  - Installing illuminate/config (v5.4.27)
    Loading from cache

  - Installing roots/sage-lib (9.0.0-beta.4)
    Loading from cache

  - Installing symfony/yaml (v3.3.6)
    Loading from cache

  - Installing hassankhan/config (0.10.0)
    Loading from cache

  - Installing brain/hierarchy (2.3.0)
    Loading from cache

  - Installing soberwp/controller (9.0.0-beta.4)
    Loading from cache

  - Installing symfony/polyfill-mbstring (v1.5.0)
    Loading from cache

  - Installing symfony/translation (v3.3.6)
    Loading from cache

  - Installing nesbot/carbon (1.22.1)
    Loading from cache

  - Installing symfony/process (v3.3.6)
    Loading from cache

  - Installing symfony/console (v3.3.6)
    Loading from cache

  - Installing illuminate/console (v5.4.27)
    Loading from cache

  - Installing roots/sage-installer (1.3.1)
    Loading from cache

  - Installing squizlabs/php_codesniffer (2.9.1)
    Loading from cache

paragonie/random_compat suggests installing ext-libsodium (Provides a modern crypto API that can be used to generate random bytes.)
illuminate/support suggests installing symfony/var-dumper (Required to use the dd function (~3.2).)
illuminate/filesystem suggests installing league/flysystem (Required to use the Flysystem local and FTP drivers (~1.0).)
illuminate/filesystem suggests installing league/flysystem-aws-s3-v3 (Required to use the Flysystem S3 driver (~1.0).)
illuminate/filesystem suggests installing league/flysystem-rackspace (Required to use the Flysystem Rackspace driver (~1.0).)
symfony/translation suggests installing symfony/config ()
symfony/console suggests installing symfony/event-dispatcher ()
symfony/console suggests installing symfony/filesystem ()
illuminate/console suggests installing guzzlehttp/guzzle (Required to use the ping methods on schedules (~6.0).)
illuminate/console suggests installing mtdowling/cron-expression (Required to use scheduling component (~1.0).)
Generating autoload files
Do you want to remove the existing VCS (.git, .svn..) history? [Y,n]? Y
> Roots\Sage\Installer\ComposerScript::postCreateProject
troymcginnis@Troys-MacBook-Pro:themes$

As you can see at the end of composer run, the postCreateProject generates no further output.

Thoughts?

Invalid scss in bulma preset

The bulma preset have a include in the _wp-classes.scss which is invalid in SCSS. I suspect that node-sass accepts it and will compile it correctly, while the recommended package sass (dart implementation) is more strict and will throw an error upon reaching this line.

The following is the line:

sage-installer/src/Presets/stubs/Bulma/styles/components/_wp-classes.scss

Line 26 in 60c329d

+tablet() {

The +tablet() sass call is equal to (when using scss) @include tablet(), changing to this will allow dart-sass to compile the code successfully.

roots / sage-installer Goto Github PK

sage-installer's Introduction

Sage Installer

Contributing

Community

sage-installer's People

Contributors

Stargazers

Watchers

Forkers

sage-installer's Issues

Description

Steps to reproduce

Versions

Additional information

Description

Steps to reproduce

Versions

Recommend Projects

Recommend Topics

Recommend Org