rootid / bpep Goto Github PK

The bpep menu entry does not appear when you press the MAJ+Alt+S shortcut.

Hi,

Final fields of a class are not taken into account to generate the builder 
code. 

I use the builder to create immutable objects.

What steps will reproduce the problem?
1. Go to a class which contains a static inner class with a constructor which a 
bunch of parameters which could benefit from the builder pattern.
2. Highlight the name of the inner class.
3. Right click on Source and select "Generate Builder Pattern Code"

What is the expected output? What do you see instead?

I would expect the listed fields to be from the inner class.  However, the 
fields appear to be from the outer class.

What version of the product are you using? On what operating system?

1.0.0 on Windows 7 with Eclipse 3.4.1.

Please provide any additional information below.

This is more of a feature request but it would be nice to have context 
sensitive support for inner classes.

Hi,

the update-site at http://boss.bekk.no/boss/ is down.
Can you fix that?

thanks

 martin

What steps will reproduce the problem?
1. In 'Java Code Style', select a prefix or suffix for fields
2. Create a class with fields
3. Generate Builder

What is the expected output? What do you see instead?
If I have a class with a field "String code_", I think the Builder should have 
a method called code(String code), but I get code_(String code_) instead.

What version of the product are you using? On what operating system?
Eclipse Indigo SR1 on Mac OSX Lion

Please provide any additional information below.

What steps will reproduce the problem?
1. Install Eclipse 3.5 on Mac OS-X 10.6.6
2. Install the plugin from the update site mention 

The source option should have Generate builder option.

There is no such option, on the source menu option.

Hi,

I am trying to use this with a mac and it says the option is not currently 
available.

In the Eclipse log file I see the following:

!ENTRY org.eclipse.equinox.registry 4 1 2011-08-29 19:14:07.021
!MESSAGE Plug-in bpep was unable to load class 
no.bekk.boss.bpep.popup.actions.GenerateBuilderAction.
!STACK 0
java.lang.UnsupportedClassVersionError: Bad version number in .class file
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:676)
    at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.defineClass(DefaultClassLoader.java:188)
    at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.defineClass(ClasspathManager.java:601)
    at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findClassImpl(ClasspathManager.java:567)
    at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClassImpl(ClasspathManager.java:490)
    at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass_LockClassLoader(ClasspathManager.java:478)
    at org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass(ClasspathManager.java:458)
    at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.findLocalClass(DefaultClassLoader.java:216)
    at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:400)
    at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:476)
    at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:429)
    at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:417)
    at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:107)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
    at org.eclipse.osgi.internal.loader.BundleLoader.loadClass(BundleLoader.java:345)
    at org.eclipse.osgi.framework.internal.core.BundleHost.loadClass(BundleHost.java:229)
    at org.eclipse.osgi.framework.internal.core.AbstractBundle.loadClass(AbstractBundle.java:1207)
    at org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension(RegistryStrategyOSGI.java:174)
    at org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension(ExtensionRegistry.java:905)
    at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension(ConfigurationElement.java:243)
    at org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension(ConfigurationElementHandle.java:55)
    at org.eclipse.ui.internal.WorkbenchPlugin$1.run(WorkbenchPlugin.java:268)
    at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
    at org.eclipse.ui.internal.WorkbenchPlugin.createExtension(WorkbenchPlugin.java:264)
    at org.eclipse.ui.internal.PluginAction.createDelegate(PluginAction.java:122)
    at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:223)
    at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
    at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
    at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4125)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1457)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1480)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1465)
    at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1270)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3971)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3610)
    at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
    at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
    at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
    at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:592)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1410)

I attached a patch (created with Eclipse) for the following 
functionality/changes. You may use it (or parts of it) as you see fit.

Additions:
- Added the action to the main "Source" menu
- Activated the action binding and changed it to Ctrl + Alt + B
- Pressing enter in the builder dialog starts the generation process
- Added an option (activated by default) to add a copy constructor to the 
generated builder (takes the respective bean and copies its members)

Changes:
- An existing builder class implementation will be replaced instead of 
appending a new class (custom changes to the class will therefore be lost)

Tested on Indigo.

What steps will reproduce the problem?
1. Create builder for existing class
2. Add property to class
3. Create builder for class again

What is the expected output? What do you see instead?
Expected: Existing builder and constructor would be updated to have the new 
property.
Actual: An additional copy of the builder is added

What version of the product are you using? On what operating system?
1.0.0-SNAPSHOT on Eclipse Helios

Please provide any additional information below.

What steps will reproduce the problem?
1. Execute "Generate Builder Pattern Code" inside a class with many parameters, 
more than the size of your screen

What is the expected output? What do you see instead?
The dialog shown should appear inside screen bounds, instead, it is rendered 
bigger than the screen.

What version of the product are you using? On what operating system?
bpep v1.0.0, Eclipse Indigo 3.7. Windows XP SP3.

Please provide any additional information below.
Providing the list of attributes to use in the builder inside a scrollable 
panel should fix the problem.

Tested in a 17" display, at 1440x900 resolution, in a class with 38 attributes.