Description

Regles : doublons, sans couleurs, possibilité d'un parametrage

Description

It should be possible to apply parameters and close params popUp when the user hit the enter key. Use the <form> and the <button type="submit"> to achive this effect

Modify the tests to make sure each it(){} is testing only one aspect of the function

Update the name of the tests if needed

Description

S'il y a 1 couleur dans la réponse, si on met dans une tentative 2 meme couleurs, il comptera les 2 bonnes

Description

I think the game style is pretty basic, maybe find solution to make it better ( colors, general design ... )

Ideas

• change font of the app ( use Roboto or smthing else) see: https://fonts.google.com/
• Change bg color and line style
• make a useOnClickOutside for poppin
• #38

Tasks

• Create a button to show all the best score ( maybe use a icon like a trophee or smthing)
• Show all the best time in all category
• create filter parameters to filter the best score

Description

Make the game responsive for all type of devices

Description

We need to improve the README of the project

We could write it in the wiki of the repository

Tasks

• Add more details for how to contribute
• Describe the architecture of the project
• Describe the technologies used

External links

• Example of a good readme(https://github.com/RomainGuarinoni/findAMusicianBackend)

https://gist.github.com/rvl/c3f156e117e22a25f242

Or use the git push --mirror [email protected]:TelecomLille/ilog22011.git command to push all the repo in the final repo

When commiting, these appear in the console :

astuce: Le crochet '.husky/pre-commit' a été ignoré parce qu'il n'est pas marqué comme exécutable.
astuce: Vous pouvez désactiver cet avertissement avec `git config advice.ignoredHook false`.

This happened when there is more than 4 indicators:

Description

Actually, all the typescript code is in one file /src/index.ts, it would be better if we create different folder and files to make a better code architecture.

Tasks

• set up webpack
• Add module to the package json
• update ts config if needed
• update architecture of code public etc...

External links

• A repo with a good configuration
• https://webpack.js.org/guides/typescript/
• https://dimitr.im/web-project-webpack-babel

Description

Instead of alert, we could illuminate the empty target, more stylish and the alerts are the worse.

Description

When you set the nbTurns of the game to 2, the tooltip is green all the rounds, it should be orange and red

Description

I think we should ignore the .js files created by tsc in the /public/js folder.

use the git rm cache command or smthing like this

Description

We have to create a README documention for the user

Tasks

• Explain the rules of the mastermind
• Explain how to play solo
• Explain how to create a multiplayer room
• Explain how to join a multiplayer room
• Explain the multiplayer rules and how to play it

Description

Use jest to unit test function

https://dev.to/paulasantamaria/document-your-javascript-code-with-jsdoc-2fbf

• add type in the jsdoc for each param like this : {String}

jsdoc.config:

{
  "opts": {
    "template": "node_modules/better-docs"
  },
  "plugins": [
    "node_modules/better-docs/typescript"
  ],
  "source": {
    "include": [
      "browser/src", "server/src"
    ],
    "includePattern": "\\.(jsx|js|ts|tsx)$"
  },
  "tags": {
    "allowUnknownTags": [
      "optional"
    ]
  }
}

what to install :

npm install --global jsdoc qunit
npm install --save-dev better-docs qunit @types/qunit

Description

The zone where the user can drag a target is pretty small. It would be better if instead of using margin for spacing, we use padding, because the zone would be widder

Description

Each best score of each category need to be store in the localStorage

Task

• Create a good way to create key/value pair in the localStorage
• At the end of each game, compare the time took by the player to finish the game and the best time store in localStorage in ther same category, if better, update the localStorage

Description

when the user start the website, it should first redirect him to the landing page where he could choose :

• to play solo
• to create a multi player room
• to join a multiplayer room

Tasks

• Add an input to past an room ID
• display error of the room does not exist ( result of the backend)
• user have to enter a name
• Add the game parameters before create a new room
• Send a backend request to have the ID of the room created

Description

Display somewhere the number of round left to the user

Idea

We could display a tooltip over the verify button that say the number of rounds left when the user over the verify button.

Something like this :

Description

Add a possibilty to close the win / loose popup witrhout start a new game to allow the user to see his game. A new button could make the win / loose popup re appear if needed

Tasks

• Add a button on win / loose pop up to close it without start a new game
• Make sure the verify button dont produce weird things when the win / loose popup is reduce
• Change verify button to see the result instead

Description

Create the backend of the app

Tasks

• add express
• add socket.io
• add PGSQL
• Dockerise everything

As seen below, the function getCurrentCombination interact with the dom :

Would be better to create a function in dom-manipulation.ts that returns the node element and then use it there !

We could use Mock function in test to mock the dependency

Description

Give the possibility to the player to choose the number of colours available for his game with a minimum of the number of possibilities and the maximum of the number of colours we created

The site https://romainguarinoni.github.io/mastermind/ sever can't render the wheel png for the params

This code should be placed under dom-manipulation.ts

Description

Add choice functional of duplicate

Tasks

Change generateCombination to take parameters into account

Add animation for the New Line with keyframe and for the old one when they slide up

Description

Github pages can host our app and we can set up CI with the github actions

Use typeORM !

Tasks

• create a room table with id, created_at,
• create player table with name, room, combination

• Caculate the time the user took to finish the game
• handle the run at the end of the game
• Show the difference between his best score and its actual score ( time comparaison)
• #63

Description

Create a multiplayer mode when a player could create a private room for 2 player, each one would have to create a secret combination and the first one to find the other combination win the game.

Tasks

• create a backend in express ( need more issues )
• create html page to determine if the player is playing solo or multi
• add the functionnality to join a room via pasting the link of a room
• if multiplayer, add the functionality to create a combination for the other player
• wait until the other player send his combination
• play the game with the other combination
• send a msg to the backend when finish
• display a loose popup if the other finish before( when receiving a msg from the backend)

External links

• socket.io
• room socket.io