SQLite doesn't cast 1/0 to true and false about rom-sql HOT 5 OPEN

"bool.cast(TRUE).as(:visible)" is a SQL statement, merely CAST(TRUE AS boolean) AS 'visible'. Setting the bool type does nothing on the casting side, it's on you. Sequel returns a string so it'll be a string. Same for all default types in rom-sql, they are nominal, with no typecasting for performance reasons.

from rom-sql.

Thanks @flash-gordon, that makes sense. That was a silly example since 'boolean' doesn't exist in SQLITE, but it's so permissive that it happens to work anyway. (and TRUE is an alias for 1).

My workaround for now is to override the initializer for my Struct with

def initialize(attributes)
  # Workaround for SQLite not having boolean type
  attributes[:visible] = attributes[:visible] == 1
  super
end

I guess the right way to do this is with a mapper?

from rom-sql.

I guess the right way to do this is with a mapper?

Yes, but you can also replace the read type, it worked for me:

    def with_visible
      select_append {
        `TRUE`.cast(:boolean).as(:visible).meta(
          read: Types::Bool.constructor { _1.eql?(1) }
        )
      }
    end

from rom-sql.

Oh nice, thanks. That works for me too.

Do you think there could be room for a ROM plugin that does this SQLite boolean coercion? It'd be nice to abstract away this quirk so it doesn't have to be done every time.

from rom-sql.

To do this, you need to swap the default :bool type with something. I don't know if this can be nicely done by a plugin. We have a dedicated namespace for Posgres' JSON(b) types: Types::PG::JSONB. We could have Types::SQLite::Bool but's not enough, we need a way to associate :bool with this particular type. I'll take a look into rom-sql's internals to see if it's possible to modify the type container for a relation.

from rom-sql.