OVER clause lost from row_number functions. about rom-sql HOT 9 CLOSED

Thanks for looking into it @solnic :) Hopefully it's not too much of a headache! 🤞🏻

from rom-sql.

Yup, all green on my side - thanks for such a quick fix!

from rom-sql.

Many thanks, my build's green again with that upgrade :)

from rom-sql.

@pat hey, thanks for the report. It wasn't easy to fix but I'm working on it in #391. The trick is to figure out how to preserve the underlying Sequel function with its opts 😅

from rom-sql.

@pat this should be fixed in 3.3.2 - please upgrade and let me know if this works for you now

from rom-sql.

Meant to report this sooner, but been caught up with other things - this fix seems to have been lost between the 3.3.2 and 3.3.3 releases? It's not present in 3.4.0 either.

from rom-sql.

@pat oh shit you're right 😭 I must've messed up release branches / master merging/rebasing 😭 I'll cherry-pick the fix commit into release-3.5 so it'll be available in version 3.5.0. Sorry about that...

from rom-sql.

No worries, completely understandable how these things happen :)

from rom-sql.

@pat 🙂 OK I just pushed 3.5.0 which includes the fix again https://github.com/rom-rb/rom-sql/releases/tag/v3.5.0

from rom-sql.