Git Product home page Git Product logo

guessing-game's Introduction

Guessing game


⚠️ DO NOT SUBMIT PRS WITH SOLUTIONS TO THIS REPO ⚠️

Description

Your task is to implement GuessingGame class

Methods:

setRange(min, max)

this method accepts min and max value of range of number to guess

guess()

this method returns solution candidate (you make an assumption based on range and previous assumptions)

lower()

this method is called if prev call of guess() returned number which is greater than answer

greater()

this method is called if prev call of guess() returned number which is lower than answer

Your implementation should use binary search algorithm under the hood to pass all tests

Prerequisites

  1. Install Node.js
  2. Fork this repository: https://github.com/rolling-scopes-school/guessing-game/
  3. Clone your newly created repo: https://github.com/<%your_github_username%>/guessing-game/
  4. Go to folder guessing-game
  5. To install all dependencies use npm install
  6. Run npm test in command line or you can run tests in browser with npm start and open http://localhost:8080
  7. You will see the number of passing and failing tests. 100% of passing tests is equal to 100p in score

Submit to rs app

  1. Open rs app and login
  2. Open RS APP and click Auto Test
  3. Select your task (guessing-game)
  4. Press the submit button and enjoy

Notes

  1. We recommend you to use nodejs of version 14 or lower. If you using any of features that does not supported by node v10, score won't be submitted.
  2. Please be sure that each of your test in limit of 30sec.

© lesnitsky

guessing-game's People

Contributors

romacher avatar shastel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

guessing-game's Issues

Неправильно составлены тесты

Для решения вашей задачи мне пришлось использовать Math.round() после деления отрезка на 2, когда в бинарном поиске (хоть в той же ссылке на Вики, которую вы прикрепили) необходимо использовать Math.floor().
Плюс по вашей логике в игре от 1 до 10 к примеру если отвечаешь на guess 5 - меньше, то рассматривается диапазон от 1 до 5, когда на самом деле должен рассматриваться уже диапазон меньше 5: от 1 до 4!

wrong task

method description, we have in task:
"lower()
this method is called if prev call of guess() returned number which is lower than answer"

test example (the very first test in guessing-game.spec.js):

it('should guess number 409 with max value 4048', () => {
const number = 409;
const game = new GuessingGame();
game.setRange(0, 4048)

let result = game.guess();
game.lower();
result = game.guess();
game.lower();
result = game.guess();
game.lower();
result = game.guess();
...

As you can see, method game.lower() called when it shoudn't (first assumption will be 2024 > 409), hence it didn't work properly.

the whole sequence of testing calls of
game.lower();
game.greater();
methods is reverted.

So maybe you should change method definitions?

Add more detailed description of method `setRange(min, max)` in README.md

Add changes to README.md

Change this:

setRange(min, max)
this method accepts min and max value of range of number to guess

To this:

setRange(min, max)
this method accepts min (not included) and max (included) value of range of number to guess,
in mathematics that would be (min, max]

Why do so

The proposed changes leave less room for ambiguity.
The solution that passes all tests does not find the min value of method setRange,
no matter how many times method lower is called.
It implies that min is not included in the searching range.
Possibly because of that a common binary search algorithm that can actually find min won't pass most of the tests.

The solution that passed 100% of the tests won't find the min value 0 of setRange(0, 4)

const game = new GuessingGame;

game.setRange(0, 4);

console.log(game.guess()); // 2
game.lower();

console.log(game.guess()); // 1
game.lower();

console.log(game.guess()); // 1
game.lower();
console.log(game.guess()); // 1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.