rokka-io / imagine-vips Goto Github PK

View Code? Open in Web Editor NEW

41.0 41.0 8.0 1.08 MB

libvips adapter for php imagine

Home Page: https://rokka.io

License: Other

PHP 100.00%

imagine-vips's People

Contributors

Stargazers

Watchers

Forkers

kdambekalns alexander-schranz batyrmastyr mehr-it yellow1912 sandstorm phareous ethaniel

imagine-vips's Issues

layers

Hello and congratulations on your release!

Re. layers, libvips can save multi-page TIFF images, and can load multi-page PDF, TIFF, and GIF. It can also load any multi-page format supported by libMagick.

It's certainly true that GIF save is not supported :(

Issue with loading animated webp

For the loaders VipsForeignLoadWebpFile and VipsForeignLoadWebpBuffer the n-Option is not being applied so no animated webp can be loaded:

https://github.com/rokka-io/imagine-vips/blob/0.31.0/lib/Imagine/Vips/Imagine.php#L237

I think there should also be those two cases:

            case 'VipsForeignLoadWebpFile':
            case 'VipsForeignLoadWebpBuffer':
                $options['n'] = -1; // not sure this should be enabled by default, to discuss
                break;

When I add those lines, i can open animated webp images without any problems. Otherwise only the first frame will be loaded, so the animation will "get lost".

Unable to obtain TIF layers using the last version of vips

It is impossible to get the layers from a tif image (there is only one layer who contains the whole image) when using vips-dev version 8.14.2-rc2 on an alpine docker image as opposed to the latest version of imagick with image magick. I saw that it said in the readme that it should work 8.7.0, does that mean I have to downgrade my version of vips-dev?

Image::save must return ImageInterface

Currently, with VIPS 8.9 empty array is returned.

imagine-vips/lib/Imagine/Vips/Image.php

Lines 427 to 442 in 5cd6490

  * @return ImageInterface 

  */ 

 public function save($path = null, array $options = []) 

 { 

 /** @var Image $image */ 

 $image = $this->prepareOutput($options); 

 $options = $this->applyImageOptions($image->getVips(), $options, $path); 

 $format = $options['format']; 

 [$method, $saveOptions] = $this->getSaveMethodAndOptions($format, $options); 

 $vips = $this->joinMultilayer($format, $image); 

 if ($method !== null) { 

 try { 

 return $vips->$method($path, $saveOptions); 

 } catch (\Jcupitt\Vips\Exception $e) {

Additionally, Layers::coalesce return nothing instead of self.
And one more thing: there are public const declarations. They were introduced in php 7.1, but php 7.0 is required.

Oh, Effects::modulate returns inexistent RokkaImageInterface.

Issue with loading animated gif file from buffer

For some reason, when loading gif from string my loader is VipsForeignLoadNsgifBuffer instead of VipsForeignLoadGifBuffer. The n option is not applied correctly.

The following addition fixes the issue (for now):

protected function getLoadOptions($loader, $loadOptions = [])
    {
        $options = [];
        switch ($loader) {
            case 'VipsForeignLoadJpegFile':
            case 'VipsForeignLoadJpegBuffer':
                $options['autorotate'] = true;
                break;
            case 'VipsForeignLoadHeifFile':
            case 'VipsForeignLoadHeifBuffer':
                $options['autorotate'] = true;
                $options['n'] = -1; // not sure this should be enabled by default, to discuss
                break;
            case 'VipsForeignLoadGifFile':
            case 'VipsForeignLoadGifBuffer':
            case 'VipsForeignLoadNsgifBuffer':
                $options['n'] = -1; // not sure this should be enabled by default, to discuss
                break;
        }
        $options = array_merge($loadOptions, $options);
        // FIXME: remove not allowed options

        if (isset($options['shrink'])) {
            switch ($loader) {
                case 'VipsForeignLoadJpegFile':
                case 'VipsForeignLoadJpegBuffer':
                case 'VipsForeignLoadWebpFile':
                case 'VipsForeignLoadWebpBuffer':
                    break;
                default:
                    unset($options['shrink']);
               }
        }
        return $options;
    }

My current vips config is:

enable debug: no
enable deprecated library components: yes
enable modules: no
use fftw3 for FFT: no
accelerate loops with orc: yes
ICC profile support with lcms: yes (lcms2)
zlib: yes
text rendering with pangocairo: no
font file support with fontconfig:
RAD load/save: yes
Analyze7 load/save: yes
PPM load/save: yes
GIF load: yes
GIF save with cgif: yes
EXIF metadata support with libexif: yes
JPEG load/save with libjpeg: yes (pkg-config)
JXL load/save with libjxl: no (dynamic module: no)
JPEG2000 load/save with libopenjp2: no
PNG load with libspng: no
PNG load/save with libpng: yes (pkg-config libpng >= 1.2.9)
quantisation to 8 bit: yes
TIFF load/save with libtiff: no
image pyramid save: yes
HEIC/AVIF load/save with libheif: no (dynamic module: no)
WebP load/save with libwebp: yes
PDF load with PDFium: no
PDF load with poppler-glib: no (dynamic module: no)
SVG load with librsvg-2.0: yes
EXR load with OpenEXR: no
OpenSlide load: no (dynamic module: no)
Matlab load with matio: no
NIfTI load/save with niftiio: no
FITS load/save with cfitsio: no
Magick package: none (dynamic module: no)
Magick API version: none
load with libMagickCore: no
save with libMagickCore: no

Should I send a PR for this fix?

Font

I would like to ask a question. Does font is still on "hold" for implementation?
Do you want to put text on the image? Please see this post if so libvips/php-vips#94

Broken link “magicksave” in readme

The “magicksave” link in the readme seems to be broken:

imagine-vips/README.md

Line 59 in b66966d

 Natively supported by libvips for saving are jpg, png, webp and tiff. If you have vips 8.7.0 with imagemagick support, it will use vips "[magicksave](https://jcupitt.github.io/libvips/API/current/VipsForeignSave.html#vips-magicksave)" for all other formats. It not, this adapter falls back to the Imagick or GD implementation. 

It should probably link here I think: https://libvips.github.io/libvips/API/current/VipsForeignSave.html#vips-magicksave

use free icc profiles

from here:

https://packages.debian.org/sid/all/icc-profiles-free/filelist

Question regarding PNG quality setting

Imagine uses the standard quality to set the png_compression_level for pngs and uses quality as fallback for all formats.

Now the Vips integration introduces png_quality but doesn't fall back to quality.

imagine-vips/lib/Imagine/Vips/Image.php

Line 55 in 86cff5a

public const OPTION_PNG_QUALITY = 'png_quality';

So when using Imagine with various libraries one easily misses to set png_quality which results in huge images that are much larger than their original when slightly scaled for example.

Setting png_quality leads to a result which is slightly worse than what IMagick can achieves.

So my question is whether the fallback shouldn't be introduced and what quality actually does? I didn't fully understand the consequence.

The final result f.e. should be in my opinion that IM scaled pngs with a quality of 90 should be nearly identical to the same png scaled with Vips and the same quality level.

Image copy does not work for animated gif file

It seems like the copy does not copy all the layers. This issue can be replicated by

Load an animated gif image
Copy it with $copy = $image->copy()
Save it (even with the option animated set to true)

The saved copy is just the first layer of the original gif image

Layers::coalesce throw an error

To manipulate animated gifs I need to call for other adapters $image->layers()->coalesce(); function so all layers are the same size so I can crop something out of that gif, but when using the vips adapter i get the following error:

VipsOperation: Klasse »paste« nicht gefunden
VipsOperation: Class »paste« not found

PHP Version: 7.3.12
PHP Vips Version: 1.0.10
Vips Version: 8.8.4

Sadly I'm not familiar how to fix this.

speedup for generateImage

generateImage has:

        // Make a 1x1 pixel with the red channel and cast it to provided format.
        $pixel = VipsImage::black(1, 1)->add($red)->cast(BandFormat::UCHAR);
        // Extend this 1x1 pixel to match the origin image dimensions.
        $vips = $pixel->embed(0, 0, $width, $height, ['extend' => Extend::COPY]);
        $vips = $vips->copy(['interpretation' => self::getInterpretation($color->getPalette())]);
        // Bandwise join the rest of the channels including the alpha channel.
        $vips = $vips->bandjoin([
            $green,
            $blue,
            $alpha,
        ]);

You can make this a bit quicker. The add() method can take an array, so you can skip the final bandjoin():

        // Make a 1x1 pixel with the red channel and cast it to provided format.
        $pixel = VipsImage::black(1, 1)->add([$red, $green, $blue, $alpha])->cast(BandFormat::UCHAR);
        // Extend this 1x1 pixel to match the origin image dimensions.
        $vips = $pixel->embed(0, 0, $width, $height, ['extend' => Extend::COPY]);
        $vips = $vips->copy(['interpretation' => self::getInterpretation($color->getPalette())]);

Add animated gif support

As libvips doesn't support animated gifs, we maybe can fallback to gifsicle for this.

Example code for creating one from an existing animated gif

    $im = new \Imagine\Vips\Imagine();
    $ori = $im->open("animated.gif");
    $i=0;
    /**
     * parse colors, loop for global options and disposal, delay from each frame with
     * gifsicle --info first and use them later instead of hardcoding
     */
    $options = "gifsicle -v --colors 256 --loop=forever -O3";
    /** @var \Imagine\Vips\Image $merged */
    foreach ($ori->layers() as $layer) {

        //merge each layer into the merged image to not have ugly transparency effects when doing operations
        if ($i > 0) {
            $merged = $merged->paste($layer, new Point(0, 0));
        } else {
            $merged = $layer;
        }
        $frame = clone $merged;
        // do the actual operation
        $frame->effects()->negative();
        $frame->save("anim$i.gif");
        $options .= " --delay 4 anim$i.gif";
        $i++;
    }

    $command =  $options . " -o animated.new.gif \n";
    echo $command;
    // run the gifsicle command
    echo `$command`;

We could of course also use imagick to do something similar instead of gifsicle, eg. the identify -verbose command (also available in PHP imagick) gives you also all the "delay, loop" information one needs, see http://www.imagemagick.org/Usage/scripts/gif2anim for inspiration. And maybe better to rely on a php extension than a CLI. gifsicle of course makes the more optimized gifs, but that could be another step.

Can't disable automatic image rotation

Hello,

Given a photo with exif-ifd0-Orientation: 6. If I load the image like the code below, the thumbnail.jpg file is rotated.

I would like to know if it's a mistake in the array_merge arguments order in https://github.com/rokka-io/imagine-vips/blob/master/lib/Imagine/Vips/Imagine.php#L209?

Also, I would like to know if there is a reason to have automatic rotation enabled?

I spotted this issue while replacing Gd by Vips in the project I work on. Because when a picture is loaded with automatic rotation, the orientation related metadata is not reset leading to the Autorotate transformation applying the rotation an other time.

<?php

use Imagine\Image\Box;
use Imagine\Vips\Imagine;

require __DIR__.'/vendor/autoload.php';

$imagine = new Imagine();

$image = $imagine->open(__DIR__.'/DSC_3513.JPG', ['autorotate' => false]);

$thumbnail = $image->thumbnail(new Box(300, 300));

$thumbnail->save(__DIR__.'/thumbnail.jpg');

stale .icc files in /tmp

I just noticed that there are many leftover .icc files in my /tmp directory:

I looked into the code, but couldn't find a spot where they are deleted after use. Is this a feature or a bug?

Use the new "delay" feature from vips 8.9 for animated gif with different delays per frame

See libvips/libvips#1346 for details and

$image = \Jcupitt\Vips\Image::newFromFile("foo.gif");
var_dump($image->get('delay'));

now returns an array with all the delays per frame

Smart crop / thumbnailing

Sorry, if this question is answered and I just didn't see it: Is there a way to thumbnail / smartcrop an image?

	* @return ImageInterface
	*/
	public function save($path = null, array $options = [])
	{
	/** @var Image $image */
	$image = $this->prepareOutput($options);
	$options = $this->applyImageOptions($image->getVips(), $options, $path);
	$format = $options['format'];

	[$method, $saveOptions] = $this->getSaveMethodAndOptions($format, $options);
	$vips = $this->joinMultilayer($format, $image);

	if ($method !== null) {
	try {
	return $vips->$method($path, $saveOptions);
	} catch (\Jcupitt\Vips\Exception $e) {