graphs's People
Forkers
duncanmakgraphs's Issues
Code review
Ideas
- Handle negatives
- Think about filtering
- allow predicates to filter/reject
- sampling? there's a lodash function for that.
Names
- File names should be more consistent.
- TextBox could be renamed to App?
React
ref
usage can be improved. For example,ref={r => this.input = r}
. See: https://facebook.github.io/react/docs/more-about-refs.html- Constructors should chain to
super
.
Code
- Merge variants of TextBox::handle@Submit into a single function?
- Redundancies in
renderUI
can be eliminated, e.g. introduce aParameter
component. x => f(x)
can be simplified intof
(except for whenthis
is involved).JSON.stringify
can be used in place ofobjectString
.- The accessor methods can have better names.
lFunc
=>label
Style
- Dangling
}
looks bad
BarGraph
- The instance variables look out of place.
- Might be interesting to share the similar parts with
LinePlot
and extra into a helper class. PerhapsData
(with methods tocalculate
, etc)? renderTopLine
- identify similar expressions and abstract by introducing methods.- Look into using
fold
orreduce
.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.