Git Product home page Git Product logo

graphs's People

Contributors

cadsit avatar duncanmak avatar roguishmountain avatar

Watchers

 avatar  avatar

Forkers

duncanmak

graphs's Issues

Code review

Ideas

  • Handle negatives
  • Think about filtering
    • allow predicates to filter/reject
    • sampling? there's a lodash function for that.

Names

  • File names should be more consistent.
  • TextBox could be renamed to App?

React

Code

  • Merge variants of TextBox::handle@Submit into a single function?
  • Redundancies in renderUI can be eliminated, e.g. introduce a Parameter component.
  • x => f(x) can be simplified into f (except for when this is involved).
  • JSON.stringify can be used in place of objectString.
  • The accessor methods can have better names. lFunc => label

Style

  • Dangling } looks bad

BarGraph

  • The instance variables look out of place.
  • Might be interesting to share the similar parts with LinePlot and extra into a helper class. Perhaps Data (with methods to calculate, etc)?
  • renderTopLine - identify similar expressions and abstract by introducing methods.
  • Look into using fold or reduce.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.