robertgr991 / php-parameter-hint Goto Github PK

I love seeing the variable names, but it would be even better to see the parameter TYPES printed out. PHPStorm has this feature:

/**
  * @param \Namespace\AccountInterface $account
  * @param string $username
  */
public function my_fun(AccountInterface $account, string $username) {...}

return my_fun({AccountInterface $account:} $theAccount, {string $username:} 'amaisano');

(the {brackets} illustrate the auto-inserted hints).

VS Code "About" / Environment

• Version: 1.62.2
• Commit: 3a6960b964327f0e3882ce18fcebd07ed191b316
• Date: 2021-11-11T20:51:30.084Z
• Electron: 13.5.2
• Chrome: 91.0.4472.164
• Node.js: 14.16.0
• V8: 9.1.269.39-electron.0
• OS: Linux x64 5.4.0-90-generic

Description

When using the toggle command "PHP Parameter Hint: Hide / Show Hints" this seems to work always when the editor has been started with the parameter hints disabled and then using the command to enable them. Then a second later, the hints appear. Everything is fine.

The other way around, however, it does work but ONLY after restarting the editor. Waiting a few seconds didn't change anything.

Ideas

IMHO it would be cool, if either

1. there is a practical way to achieve an immediate change both ways or
2. if there is a way to require a restart such that the user is presented with a simple way to restart the editor (restart button) or simply presented with a notification that this command requires a restart of the editor.

I'm not very familiar with VS Code extension development, but I wouldn't be surprised if this is beyond the control of the extension. Can anyone verify this behavior and if so, what can we do about it?

Undoing didn't reprocess to show parameter hints back in place

for example lets say u have something like

/**
 * @param array<int|string, BasePackage> $installedMap
 */
public function getPrettyString(RepositorySet $repositorySet, array $installedMap) { ... }

now the hint will be showing as

$this->someclass->getPrettyString([array] $x, [RepositorySet] $y)

which is incorrect.

Hello is there a way i can set background opacity and padding? There's too much unnecessary padding

I'm used to dimmer font and background color, for example how it is implemented in a similar extension IntelliJ Parameter Hints.
Indeed, this extension is more powerful than the other one above. It provides more hints, for example in nested structures, where they are also more properly indented. It would be great if it was even more customizable.

Hi. I've noticed high CPU usage from VS Code using the extension while working with PHP files.

When I start VS Code without any PHP file open, the CPU usage is normal, almost 0% after cache CSS and JS, but when I open a PHP file from the project, the CPU usage goes to 50% and after the parameters are load it goes down to 30%. Closing the file and even reloading the window the CPU does not go down, only after I close VS Code completely and start again without any PHP file open.
I did the same process but with the extension disabled, and the CPU usage with the PHP file open was almost 0%.

Extesion enabled:

Extension disabled:

I tried to debug the JS performance with Running Extensions and start debugging, and noticed that the extension is in process all the time after opening the file and even after closing it.

I really like this extension, it's a great helper and I would not like to stop using it.

OS: Windows 10 Pro 64-bit
RAM: 16 GB
CPU: Intel Core i5-4590
VS Code version: 1.49.0
Node version: 12.14.1
PHP version: 7.3.12
PHP Parameter Hint version: 0.5.0

I pasted one comparison in an if over the top of another one, the result was parameter references splitting the data. It's like it needs to reprocess any code pasted in and didn't instead keeping the parameter hints super-imposed where they were.