Describe the bug

It looks like the conditional check for selinux_reboot is incorrect. At least it's not working under Ansible 2.9.6+.

Playbook

requirements.yml:

---
roles:
  - name: robertdebock.selinux
    version: 2.6.1

playbook.yml:

---
- name: Configure server
  hosts: HOSTNAME
  roles:
    - name: robertdebock.selinux
      selinux_state: enforcing
      selinux_reboot: false

Output

TASK [robertdebock.selinux : test if selinux_reboot is set correctly] **********************************************************************************************************************************************
fatal: [HOSTNAME]: FAILED! => {"msg": "The conditional check 'selinux_reboot is bool' failed. The error was: template error while templating string: no test named 'bool'. String: {% if selinux_reboot is bool %} True {% else %} False {% endif %}"}

Environment

• Control node OS: Pop!_OS 20.04 LTS
• Control node Ansible version: 2.9.6
• Managed node OS: CentOS 8.2.2004

Proposed feature

Thanks for this awesome collections of roles.
To be able to manage as much as possible things related to selinux I would propose to integrate .seport tools in this role.

In README -
"Install and configure selinux and its required libraries on your system."

sorry ;)

Describe the bug

The robertdebock.selinux role version 2.3.5 (pulled from Ansible Galaxy) is missing required python3-policycoreutils package in vars/main.yml for RedHat:

  Amazon-2018: *rhel7
  RedHat:
    - python3-dnf
    - python3-libselinux
    - python3-libsemanage
    - python3-policycoreutils # <- NEW

This does NOT break the selinux role, but it can cause other roles to break. For example, if I use robertdebug.selinux set to enforce, and then subsequently use the robertdebock.httpd role, the latter fails at:

- name: modify selinux settings
  seboolean:
    name: "{{ item }}"
    state: yes
    persistent: yes
  when:
    - ansible_selinux.status is defined
    - ansible_selinux.status == "enabled"
  loop: "{{ httpd_sebooleans }}"

because the Ansible seboolean module fails due to the missing policycoreutils package.

Thanks,

Jim Reuter

Describe the bug

Running a playbook with the role leads to the following error:

ERROR! couldn't resolve module/action 'selinux'. This often indicates a misspelling, missing collection, or incorrect module path.

The error appears to be in '~/.ansible/roles/robertdebock.selinux/tasks/main.yml': line 12, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

- name: manage selinux
  ^ here

Playbook

- name: Update system and enable SELinux
  become: true
  hosts: all
  roles:
    - role: robertdebock.selinux
      vars:
        selinux_state: enforcing
        selinux_policy: targeted
        # Should the machine be rebooted after changes?
        selinux_reboot: no
  tasks:
    - name: Update system
      command: yum upgrade -y

Environment

• Control node OS: MacOS 19.6
• Control node Ansible version: 2.10.0
• Managed node OS: Amazon LInux 2