robere2 / portfolio Goto Github PK

If a user has an error, it should be logged to Sentry.

<a> tags should have rel="noopener"

404 pages, for example, should have their own design & branding as opposed to Azure's default.

When using a touch screen, RepeatingList needs to be touched twice before scrolling will work. This is probably just a matter of adding the :focus state.

It looks like the Azure deploy action is attempting to run whenever Dependabot submits a PR. I think that I originally just used the template provided by Azure with some minor modifications and didn't test too thoroughly. Interestingly it doesn't happen for me.

This could be a security concern if it happens for any user other than myself.

For Azure, the Microsoft logo was originally used as a placeholder. It should be replaced with the actual Azure logo.

This was noticed on an iPad, year currently unknown. The custom FontAwesome icons must be recognized as a utf8 character and rendered as that as opposed to the icon that it's supposed to be.

I believe the emoji was 👨‍🦰, or something like it, and the icons were C/C++ and MongoDB.

Contact form has no protection at the moment. An Azure function should be set up for Google reCAPTCHA.

On larger screens, the headshot can sometimes be uncomfortably close to the title text. It should be moved further left.

<a> elements should by default have their color equal to var(--primary).

A Terms of Service and Privacy Policy should be added to the webpage. Since this is a static page, not much is needed, but it should be added anyway. Especially if I decide to add analytics.

The Azure Function worker currently is using an older version of node. Ideally it should be updated to Node 16, but during my trials last night I had trouble getting it to work.

Much of the text on the website was placeholder text, intended to be replaced later. The time has come for that.

This includes adding more info to the projects section.

The CSS smooth scrolling should be added, ideally, however due to how the RepeatingList works, it currently breaks it by immediately stopping the scroll when <a> links to hashes are clicked. Therefore the RepeatingList should scroll its content in some other way, if possible.

Metadata for the webpage when embedded on other sites such as in Twitter cards or Google searches can be improved.

The RepeatingList probably is not accessible, since it is adding and removing elements to and from the DOM. An invisible list should be available for screen readers instead.

The GitHub repository and its code is not structured in a friendly way at the moment. A better README should be added, along with any necessary tooling.

Originally I didn't want to use TypeScript to keep dependencies as low as possible, but I think there's benefit to using it in this case.

Setup should be easy since Vite is used.

Would be interested in using this myself. But as you haven't got a license; I don't want to be breaking anything. Thanks

Contact Form inputs are missing:

• labels
• placeholders

CD is already added but some simple CI could be useful. Particularly for code analysis and linting.

At the moment, the only way to tell if a contact form submission is coming from the contact form or from email directly is to look at the from address. There should be some more obvious way to tell whether an email is from a contact submission, such as [Contact] as a prefix.