Git Product home page Git Product logo

usemlog's People

Contributors

andreihaidu avatar bbferka avatar bunk96 avatar joserochh avatar sanic avatar sunava avatar xxjunxx avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

usemlog's Issues

SymbolicLogger::FinishImpl GetWorld() return nullptr

When FinishImpl is called from destructor, GetWorld() return nullptr. Should I remove this from destructor?

void ASLSymbolicLogger::FinishImpl(bool bForced)
{
	if (bIsFinished)
	{
		UE_LOG(LogTemp, Warning, TEXT("%s::%d Symbolic logger (%s) is already finished.."),
			*FString(__FUNCTION__), __LINE__, *GetName());
		return;
	}

	if (!bIsInit && !bIsStarted)
	{
		UE_LOG(LogTemp, Warning, TEXT("%s::%d Symbolic logger (%s) is not initialized nor started, cannot finish.."),
			*FString(__FUNCTION__), __LINE__, *GetName());
		return;
	}

	EpisodeEndTime = GetWorld()->GetTimeSeconds();

Dynamically adding LevelInfo properties

It would be nice to add LevelInfo properties at BeginPlay(), so I suggest taking the following code from void ASLRuntimeManager::PostInitializeComponents() and move it to void ASLRuntimeManager::BeginPlay()

		// Add level info to the metadata
		for (TActorIterator<ASLLevelInfo> InfoItr(GetWorld()); InfoItr; ++InfoItr)
		{
			for (const auto& PropItr : InfoItr->LevelProperties)
			{
				EventDataLogger->AddMetadataProperty(MakeShareable(new FOwlTriple(PropItr)));
			}
			break;
		}

That way users are able to add LevelInfo properties depending on certain conditions instead of editing the LevelInfo in the editor.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.