robcharlwood / django-mothertongue Goto Github PK

django-mothertongue's abstract model overrides the getattribute() method to return attributes of a translated model. This is causing multiple hits to the database even when returning the same attribute for the second time.

We need to find a way to reduce these hits possibly by overriding the getattr() method instead. This issue is no show stopper for sites receiving small or medium amounts of traffic but could become an issue on heavy traffic websites and so this does need fixing.

Hi,

I’ve used this application for a website and after putting it in production I noticed a wrong behavior that might need a correction.

The website supports English and French, English being the default and setup language. I’ll illustrate the problem on the GenericPage model example. (http://packages.python.org/django-mothertongue/usage.html). I create an instance of that model from the admin page with the corresponding French translation. On the site the correct values are showed of the page depending on the browser settings or the url. I can also easily modify the content of the page from the admin site. My browser has English as the preferred language. Everything is fine at this point. Now a colleague, who has French locale set in his browser, connects to the admin site to modify the page I previously created. The interface is in French as expected, but when he gets to the change form of the GenericPage instance, both the original fields and the translation inline have the same values. If he saves the changes, the default English fields are overwritten as well as the inline. Then, if we configure another language, the Russian for example, the administrator who’ll have Russian locale will see the Russian values in the original form and two inlines, Russian and French, but never the English as expected. The only way to solve this is to always manually change the URL to English (en), losing the translated admin site, which is not very inconvenient and error prone.

Would there be a quick fix to this? As the only thoughts I could think of was to in a way to override the ModelAdmin.change_view() to force the retrieval of the correct values or make some custom processing on the Middleware level.

Thanks in advance for any help.

Cheers,

In docs there is example of using django-mothertongue

# chunks translations model
class GenericPageTranslation(models.Model):
    generic_page_instance = models.ForeignKey('GenericPage', verbose_name=_('generic_page'))
    language = models.CharField(max_length=len(settings.LANGUAGES)-1, choices=settings.LANGUAGES[1:])

Field language should have max_length = 10 (оr greather), but not len(settings.LANGUAGES)-1