robcalcroft / monzoweb Goto Github PK

An auth code such as code=234234jiio=34234v will break the auth process as the code will split the string on the = and as such only 234234jiio will be seen as the auth code.

Fix is changing '=' in the .split() to be /^[A-Za-z0-9]+=/

The fix for #59 broke the view of the login screen; this should be a better fix

When clicking on a transaction that has some data missing or unavailable in memory, it errors in the console.

The expected behaviour is that it should either error with an informative message or perform a network call to collect the data as happened before.
This was introduced in #46

Active tabs appear to be broken

Remove instances of .bind(this) in render functions and bind them in the constructor.

https://github.com/airbnb/javascript/tree/master/react#methods

Insecure content warnings on chrome when running with HTTPS

As per https://github.com/airbnb/javascript/tree/master/react#quotes, ensure JSX files use double quotes for params.

Investigate UI testing frameworks and implement

Removes need for repeated code

ajaxFail currently lives in the main component, it needs to live in the utils.js file so that it can be imported into any component.

Mondo logo needs left padding removed

Use https://github.com/airbnb/javascript over the current implementation.

Categories contain underscores in their raw form; these should be stripped out.

Things bought online or through PayPal often have a rather ugly overview as there is not much info to show. Make the Overview component more robust in dealing with this and attempt to further hide locations if they are not relevant etc.

Potentially replace the fallback icon.

Would be cool to have the categories in here.

• Filter by category
• Show icon for each category
• If there's no image use the category icon

Code does not catch a lack of suggested tags in a transaction.

As of June 2016, Google Static Maps API requires an API key to be provided as part of the request [1].

The details panel for individual transactions uses this API to generate the map behind the merchant logo and currently results in a 403 error due to the key not being provided.

(I'll be creating a PR shortly with a fix)

[1] - https://googlegeodevelopers.blogspot.co.uk/2016/06/building-for-scale-updates-to-google.html

Convert this:

Into this:

Before the initial transaction list shows up, the user is not told that the content is loading.

At the moment there are loading bars for the transactions.

If we optimistically loaded the UI (so show the content as it appears) it'll make this feel a lot faster.

After all the awesome work @zaccolley has been doing I wanna do a release. Using semver for this project I believe the changes we made are technically breaking API changes? So we'll need a version bump to 2.0.0.
We'll need to update the CHANGELOG with all our changes. I usually do this by filtering the issues by date since the last release but some of @zaccolley 's PRs have have a lot of changes that may not have been fully covered in the issue. As such can we start to compile a list here of changes to go into the CHANGELOG for the next version.

To do

• @zaccolley to compile list of changes in his PRs / issues
• @robcalcroft to compile list of changes since last release from other contributers and other fixes
• Create release candidate
• Bump package.json to new version number
• Append CHANGELOG documenting changes and changes to note for users in terms of usability eg breaking changes

Show the amount of the transaction in the local currency in the main sidebar

The map loads correctly but cannot seem to be interacted with

Could do with bumping this back up to the latest (4.2.0) as there seems to be problems building under Windows and Linux (not tried under MacOS). It is not consistent between the two but builds OK if specifying node-sass v4.2.0 in package.json.

Issue related to 85fe404 appears to be fixed but could do with being confirmed.

Basename is specified in the HTML currently, needs to be in the JS. Error appears in prod builds

Currently the app is only written to deal with one account, if the user has multiple accounts it will use the first. Most people won't have this issue but this could become an issue as Mondo grows.

In the menu, 'Logout' is shown regardless of login status. Check in localStorage for an access token to determine login status

Log will show improvements and fixes resolved in the release

Have a section showing previous visits and averages as per the Mondo iOS app

Would be great to add Redux to manage state - big job though!

Big one. Only do if this needs it - aka loads of users use it - but would be nice to have.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA#Getting_Started_with_ARIA

Currently if the access token or refresh token is rejected then the app simply informs the user. The app should additionally remove the current credentials from the cache forcing the app to re ask for authentication.

It's kinda just there and doesn't play nice with React

Declined transactions are showing as normal with no note that they were not taken

https://www.muicss.com/

Transactions in the list only show declined if "INSUFFICIENT_FUNDS", in the transaction drill down it shows all declined types but only with the message "Declined as you don't have sufficient funds on your card"

Names not showing when doing a P2P transfer

jQuery is bulky; need something lighter, Fetch polyfill looks good

If there are multiple transactions at the same location, the label should be updated to reflect the number of occurrences of transactions at that location

Not sure what's going wrong here, but this is what I'm seeing when I try to login in development mode. I have my client ID etc in the .env file. Notice the client_id=undefined&redirect_uri=undefined in the URL.

After the name change all instances of 'Mondo' need to become 'Monzo'

Your client ID is hard coded into the link for the "Login" button - doesn't take the value from the .env file

Currently we filter locally on cached content. Need to search remote too as default call doesn't return more than 100 transactions.

Plot all transactions on a Google static map, allows user to see trends in spending and locations

Refresh token is given to the client but not utilised, need to ensure a new access token is issued to the client and the app state reloaded with the new data

Local cost seems to missing from the transaction summary.

Amounts that are less than £1 eg £0.72 are being shown as £72

We could use a different option than Google Maps.

Something like Leaflet with Wikipedia's map tiles: https://www.mediawiki.org/wiki/Maps

This would remove any need for API keys.

Empty chip component when there's no tags

Combine the map and the home page.

The map will always be in the background and then selecting a item will focus the map to that place?