Using the Shepherd events about ember-shepherd HOT 7 CLOSED

Yeah, you should totally be able to do that. Let me write up a test case as an example to demonstrate, and if it doesn't work I'll add that feature.

from ember-shepherd.

@davidpike7 so, you should already be able to do that with something like this:

triggerFlashMessage: on('init', function() {
  const tour = this.get('tour');
  tour.on('complete', function() {
    // Tour has been cancelled
  });
})

However, I really like the use of on to clean that up a little. I'm not sure how on works with the Evented mixin that Ember provides, which is what the tour service uses. I'll look into that, though.

from ember-shepherd.

So, I tried getting the syntax that you used working and found some confusing behavior. It seems like Ember.on works with the Ember.sendEvent method. I created an object set up like this:

  var someClass = Ember.Object.extend({
    tour: service,

    testOnInit: on('init', function() {
      var tour = this.get('tour');
      tour.on('start', function() {
        assert.ok(true, 'The `start` event was observed from the init hook');
      });
    }),

    tourDidStart: on('tour.start', function() {
      assert.ok(true, 'The `start` event was observed using the `on` helper');
    })
  }).create();

and only the hook set up in the init method was run. I'm not sure if it's possible to get it to work with the Ember.on method as well, but this Stack Overflow post seems to suggest that the events are not compatible with one another.

from ember-shepherd.

Nice work. Keep me posted with how you get on!

from ember-shepherd.

Sorry I just now saw this issue, GitHub doesn't notify me well about activity on this repo, for some reason.

from ember-shepherd.

So should we close this issue @alexlafroscia ?

from ember-shepherd.

Yeah, I'm pretty sure that it's not something that Ember supports right now, as the test I wrote in #20 shows

from ember-shepherd.