Tours are not testable about ember-shepherd HOT 6 CLOSED

@grapho You are totally right, we had a lot of updates to make to get this to the current Shepherd API! I just opened a PR to update all that. Mind trying it out?

from ember-shepherd.

@grapho I'm not sure I understand. Can you not change the target of the test helpers? You can pass document.body as the context for the tests, rather than the default of the Ember testing container.

from ember-shepherd.

Also, why do you need to fork to expose modalContainer? Can't you pass that option currently as part of your steps/tour config?

from ember-shepherd.

@rwwagner90 Thanks for the response!

I resolved the issue with the test helpers, so we can close this issue. I may have posted the issue in a moment of temporary frustration :p

However, I did take a look at the tour service in the addon repo... i do not see modalContainer being passed to or set onto the tour instance, so I just did a quick fork to test that theory.

from ember-shepherd.

I resolved the issue with the test helpers, so we can close this issue. I may have posted the issue in a moment of temporary frustration :p

No problem! We have all been there 😃

However, I did take a look at the tour service in the addon repo... i do not see modalContainer being passed to or set onto the tour instance, so I just did a quick fork to test that theory.

There is not an explicit option in the service for it, but I think it can be passed as part of your vanilla Shepherd config perhaps? I could be wrong. Let me know what you find!

from ember-shepherd.

There is not an explicit option in the service for it, but I think it can be passed as part of your vanilla Shepherd config perhaps? I could be wrong. Let me know what you find!

Confirmed, setting defaultTourOptions.modalContainer on the tour service does not do anything on its own.

I could attempt to set the property directly onto Shepherd object.. but as far as I can tell, Shepherd is not instantiated until addSteps is called which is too late (according to the api docs)

From reading the code it seems the Tour Service grabs its config setting that it has defined and passes them into Shepherd object when it gets initialized

from ember-shepherd.