robbi-blechdose / trispace Goto Github PK

I love TriSpace and am currently modifying it and playing around with it. Here are some quick bugs I've found before I completely forget:

In starmap.c:

static GLuint sunTextures[2];

^ You have 3 suns so this is currently overflowing - should be [3]

In spacedust.c:

                spacedust[i].x = spacedust[i].x * cosf(angle) - spacedust[i].y * sinf(angle);
                spacedust[i].y = spacedust[i].x * sinf(angle) + spacedust[i].y * cosf(angle);

^ You want to be saving the result of what the new spacedust[i].x should be and assigning it after calc'ing spacedust[i].y. Currently if you roll in circles you'll see the stardust gradually gets closer to the middle (and that's because the new .x is being used to create the new .y)

In equipui.c:

    char buffer[29];
    char name[21];
    char status[4];

^ You are currently overflowing these buffers.
e.g.

sprintf(buffer, "%-19s %4d %4s", name, getPriceForEquipment(i), status);

19+1+4+1+4+1(null terminator) = 30
This happens in other areas too - no need to be quite so tight with our stack on FunKey (so could just make all string arrays [100] :) )

main.c

transferCargo(&player.hold, &stationHold, uiTradeCursor, &starSystem.info, 1);

^ This should be passing &starSystem.info.characteristics not &starSystem.info for these calls to transferCargo

TriSpace is absolutely brilliant - thanks for all the work you clearly put into this and for releasing the source.

-Nick (aka LordEnum)