robathedtek / jquery-sparkline-rails Goto Github PK

Due to the string comparison in engine.rb, version checking will always fail when using Rails 3.2.1x or higher.

[4] pry(main)> ::Rails.version
=> "3.2.11"
[5] pry(main)> ::Rails.version >= "3.2.2"
=> false

Best fix I could find is something like this:

Gem::Version.new(::Rails.version) >= Gem::Version.new("3.2.2")

• Accept the open merge request
• Publish the gem on rubygems

Following the instructions in the readme, but somehow this isn't adding to my Rails project.

As mentioned in the readme, I added the gem to the Gemfile with the reference to the github link, followed with a 'bundle install', added "//= require 'sparklines'" to my application.js file in the asset pipeline, but any page requested returns with an error saying "couldn't find file 'sparklines'". Running 'gem list' showed that the gem was not included in my gems (although the 'bundle install' showed that the files were indeed being fetched from this repo).

If I do another 'bundle install', I see the line

"Using jquery-sparkline-rails (2.0.0) from https://github.com/RobAtHedtek/jquery-sparkline-rails.git (at master)"

After tweaking a few things, I couldn't get it to work, so I defaulted to the manual "gem install jquery-sparkline-rails", which returned with the following error

"ERROR: Could not find a valid gem 'jquery-sparkline-rails' (>= 0) in any repository"

I really would like to see some sparklines on my page!

Thanks in advance,

-Max