rmosolgo / graphql-ruby-demo Goto Github PK

Would it be valuable to support the same behaviour as implemented in graphql/swapi-graphql project? Users will be able to run the same example queries and compare implementations.

I've been having a heck of a time over the last couple of days trying execute a Relay query to fetch a node via id. I have been able to reproduce the problem with this project (even running GraphiQL from the Heroku hosted project). Basically, if you try to execute the query located in https://github.com/rmosolgo/graphql-ruby-demo/blob/master/app/graph/queries/introQuery.graphql, you get the following error:

{
  "errors": [
    {
      "message": "Something went wrong during query execution: wrong number of arguments (given 2, expected 1)"
    }
  ]
}

In my own code, I have updated it to use the github repository for graphql-ruby instead of the gem. Now I get a different error:

{
  errors: [
    {
      "message": "Internal error"
    }
  ]
}

Not sure what is going on here. I thought I was doing something wrong, but I'm assuming the query above should work, so perhaps it's a bug?

i was try your app in local its work but when i check ur app on heroku it does not work please would you like to check that is error and why
i am new in GraphQL and Rails so i could find it yet

NodeIdentification as defined in app/graph/types/node_identification.rb is outdated and can be removed, see http://rmosolgo.github.io/graphql-ruby/relay/object_identification

# Todo: handle code reloads!
GraphQL::Relay::GlobalNodeIdentification.instance_variable_set(:@instance, nil)

NodeIdentification = GraphQL::Relay::GlobalNodeIdentification.define do
  object_from_id -> (id, ctx) do
    type_name, id = NodeIdentification.from_global_id(id)
    type_name.constantize.find(id)
  end

  type_from_object -> (object) do
    StarWarsSchema.types[object.class.name]
  end
end

When running the demo on heroku or on localhost I get the following error.

Don't know how to get the GraphQL type of a Droid 

@rmosolgo - In this demo, how does graphiql get the schema to show you on the right side bar? Does it do an implicit introspection query when it starts up?

I would like to beef up this application in order to provide examples of more advanced usage. I have a few possibilities in mind:

• Pick a domain with familiar but interesting data
• Accept inputs from users (no user-supplied text, though)
• Make a JS front-end (vanilla JS? Apollo? Relay?)
• Demonstrate some common practices:
  • GraphQL::Batch + ActiveRecord
  • Relay-compliant mutations
  • Dynamically-generated types and fields
  • Custom Scalar?
  • Simple Authorization

Is there anything else that could be added to make this demo more useful?

https://github.com/rmosolgo/graphql-ruby-demo/blob/master/app/graph/queries/readLukesFriends.graphql

Running this query

query readLukesFriends {
  luke: human(id: 1000) {
    friends { name }
  }
}

http://graphql-ruby-demo.herokuapp.com/graphiql?query=%7B%0A%20%20luke%3A%20human(id%3A%201000)%20%7B%0A%20%20%20%20friends%20%7B%20name%20%7D%0A%20%20%7D%0A%7D

Returns

"Field 'name' doesn't exist on type 'CharacterConnection'"

But this query works:

luke: human(id: 1000) {
    friends {
      edges {
        node {
          name
        }
      }
    }
  }

This documentation is great: https://rmosolgo.github.io/graphql-ruby/relay/mutations but I'd love to see how mutations should be done by looking in this demo app.

Firstly, thank you so much for this repo, its been incredibly helpful to me. Thanks largely to this repo I've been able to get a batched GraphQL endpoint running over a rainy weekend 😄

One thing that I didn't understand, is the QuerySet class legacy, or is it implicitly used somewhere? GH search doesn't show any references to it around the repo.

In addition, the files in app/graph/queries don't appear to be referenced by anyone besides QuerySet, so are these legacy too? I was under the impression that GraphQL provided a way to whitelist queries such that an internal API could not be abused to access unintended data, and wondered if it was related to this directory

For a quickstart demo helper, it would be helpful for me to see how to define a date type and use it in a schema