Comments (3)
Err. Just noticed that the Piff.Star
objects we attached here are exactly 21x21 pixel stamps. So it's not unreasonable for Piff to fail to extrapolate to 25x25 (though maybe that'd also be a reasonable thing for Piff to warn about). We should try again with larger input stamps.
from piff.
Thank you for noticing that, @jmeyers314 ! Making sure our psf candidate sources are as large as the model size seems to have done the trick, and I'm implementing checks in our code to try to prevent this in the future.
I've updated the issue title here: PIFF should error out if the configured PixelGrid is larger than the star images that are given as input to the fitter. That would have helped us catch this earlier.
from piff.
It's hard to anticipate all the ways users can fail to use code appropriately. :) But yeah, I agree this is something that Piff should check for and give an appropriate error earlier in the process.
from piff.
Related Issues (20)
- Caching atmospheric params to be more efficienct about making diagnostic plots HOT 11
- Quality checks in Input.makeStars() HOT 17
- Add additional models in optical_model.py HOT 9
- Added functions need by optatmo to the util.py HOT 8
- Add a normalization option HOT 8
- Add calculate_moments function to util and associated unit tests. HOT 1
- PSF wings HOT 2
- Reading WCS solution of ZTF images HOT 1
- Stars Center on the stamps HOT 7
- psf.draw | wcs is not a list for single chip fit HOT 5
- Add equality testing HOT 1
- very large PSF (after re-installation) | Bad fit HOT 6
- regularize in a hacky way HOT 3
- Examples in documentation & `examples/` fail for v1.2 HOT 3
- Inconsistent piff log message levels HOT 2
- Fix max_snr weight adjustment.
- Make it easy to run just the star selection without fitting a PSF model
- incorrect error message with missing keyword
- coadd_object_id in psf_stars extension is stored as an f8 instead of an i8 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from piff.