Git Product home page Git Product logo

Comments (3)

jmeyers314 avatar jmeyers314 commented on July 22, 2024 1

Err. Just noticed that the Piff.Star objects we attached here are exactly 21x21 pixel stamps. So it's not unreasonable for Piff to fail to extrapolate to 25x25 (though maybe that'd also be a reasonable thing for Piff to warn about). We should try again with larger input stamps.

from piff.

parejkoj avatar parejkoj commented on July 22, 2024

Thank you for noticing that, @jmeyers314 ! Making sure our psf candidate sources are as large as the model size seems to have done the trick, and I'm implementing checks in our code to try to prevent this in the future.

I've updated the issue title here: PIFF should error out if the configured PixelGrid is larger than the star images that are given as input to the fitter. That would have helped us catch this earlier.

from piff.

rmjarvis avatar rmjarvis commented on July 22, 2024

It's hard to anticipate all the ways users can fail to use code appropriately. :) But yeah, I agree this is something that Piff should check for and give an appropriate error earlier in the process.

from piff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.