Stars Center on the stamps about piff HOT 7 CLOSED

I'm pretty sure makeStars does choose the stamps so that the given position (from x_col, y_col) is as close as possible to the center of the stamp. I suspect the confusion is that these positions are assumed to be FITS-style positions, not numpy. That is, the center of the lower left pixel of the full image is considered to be (x,y) = (1,1), not (0,0).

These are the positions that show up if you open the image in, say, ds9 or some other standard astronomical image viewing software. And notably, (1,1) offset from what you get from things like matplotlib's imshow.

from piff.

It definitely could be that.

Should I change my code such that the conversions are RA,DEc-> x_col, y_pos in FITS-style or is there a way to tell PIFF that the values I am giving are numpy ?

I would prefer the latter as I think numpy formating is more standard (and matchs with matplotlib). But I could make the trick inside my code.
Thanks

from piff.

I am now shifting the x_cos, y_col by -1 to follow the fortran/fits format when creating the catalog that enters PIFF.

It solves the issue.

from piff.

Good. I'd much rather keep the convention of matching other astronomy software than some particular plotting package, so I think we should leave it as is. Especially since most input catalogs (e.g. any from SExtractor or the LSST stack) will be using this convention, not the numpy one. (I.e. your convention is very much not more standard.)

However, we could consider adding optional parameters xoffset and yoffset, which you can set to 1 as a way to apply an offset to the input positions. This way, you wouldn't need to rewrite new catalogs if you for whatever reason made catalogs with the numpy convention.

from piff.

That could be an idea, and indeed, numpy convention might actually not be the standard in astronomy.

from piff.

The Rubin code sets the centre of the bottom-left-hand pixel to be (0.0, 0.0), which is off-by-one from FITS (but consistent with 0-indexing in C and python)

from piff.

Ah, good to know. Thanks.

from piff.