Colorscheme light/dark about onenord.nvim HOT 10 CLOSED

Hey! This is what we had before but I wasn't sure of the interactions with background at the time but I think this is doable, it seems that tokyonight does something similar.

from onenord.nvim.

Hey!
Great to see you responding and commiting this quick :-D
Is it possible there is still something not 100%
Im now able to quickly switch between dark and light (thanks), but for example my telescope and wilder menu is not switching to light but remains dark (i did the test with other themes and there this just works).

from onenord.nvim.

No problem! Hmm that's strange, for me telescope changes fine but I think I see something similar with notify where the notification is in the previous color if it's already in progress but then the next notification will be the right color. But I also get this with other themes like tokyonight, so I don't think its exclusive to this theme.

Do you mean that the telescope colors don't change at all, even if you open a new one?

from onenord.nvim.

Indeed, opening a new telescope window or the autocomplette window,.... they all stay in the dark theme even when opening a new one.

from onenord.nvim.

This doesn't happen for me when using the default config or the colors provided by require("onenord.colors").load(), I think it has to do with your config? I noticed you are overriding some groups with custom colors and these won't change when switching to the light theme. I suppose it could be possible to add theme specific customizations if it would be helpful, maybe something like:

  custom_highlights = {
    dark = { ... },
    light = { ... },
  },

And similar with the custom colors.

from onenord.nvim.

You are correct, it was my config.
Thanks!

from onenord.nvim.

No problem! Feel free to let me know if you think the customizations per theme would be helpful or not 😄

from onenord.nvim.