Git Product home page Git Product logo

Comments (15)

hacktivateit avatar hacktivateit commented on August 23, 2024 4

fixed!

from onenord.nvim.

hacktivateit avatar hacktivateit commented on August 23, 2024 2

Ok, i think i found the issue, it's IndentBlankline

After setting some colors for the plugin groups everything works perfectly, here the docs https://github.com/lukas-reineke/indent-blankline.nvim/blob/master/doc/indent_blankline.txt

The groups are

IndentBlanklineChar
IndentBlanklineSpaceChar
IndentBlanklineSpaceCharBlankline
IndentBlanklineContextChar
IndentBlanklineContextSpaceChar
IndentBlanklineContextStart

I don't know why Alacritty behaves differently

maybe you can add support

from onenord.nvim.

rmehri01 avatar rmehri01 commented on August 23, 2024

Hey! I don't have a Linux machine so I can't test this but it seems kind of strange that it works in other terminals. Is the cursor supposed to match the foreground color of what it is on because I don't think that dark blue color is used anywhere?

from onenord.nvim.

hacktivateit avatar hacktivateit commented on August 23, 2024

yes, the color showed by Alacritty is the right one

Also Konsole is affected
image

Switching to a similar colorscheme like nordic solve the problem
tilix:
image

from onenord.nvim.

rmehri01 avatar rmehri01 commented on August 23, 2024

Could you try changing the highlights for the Cursor group and see if that's what controls it?

from onenord.nvim.

hacktivateit avatar hacktivateit commented on August 23, 2024

how?

from onenord.nvim.

rmehri01 avatar rmehri01 commented on August 23, 2024

Something like :hi Cursor guifg=red guibg=green and see if that changes how it looks?

from onenord.nvim.

hacktivateit avatar hacktivateit commented on August 23, 2024

nothing changes, both in Alacritty and Tilix

from onenord.nvim.

rmehri01 avatar rmehri01 commented on August 23, 2024

Oh okay interesting, thanks for looking into it, I'll add those!

from onenord.nvim.

rmehri01 avatar rmehri01 commented on August 23, 2024

Actually before doing that, I think that these groups by default take from Whitespace and Label which are gray and purple respectively so I'm curious why the blue is showing up. Do you know what group that is from specifically and can you do :hi <group> to get the hex code?

My Indent Blankline groups look like this:

image

from onenord.nvim.

hacktivateit avatar hacktivateit commented on August 23, 2024

here we go, i searched the highlights with telescope, like you did

image

My setup for debug this is pretty simple
NVIM v0.8.0-dev-996-g090370263
Packer as package manager
Onenord and IndentBlankline installed and managed with packer (obviously)

onenord config is the simplest possible:
require('onenord').setup()

indentblankline config is the simplest possible:
require("indent_blankline").setup()

Packer setup is literally this

require('packer').startup(function(use)
	use 'wbthomason/packer.nvim' -- Package manager
	use 'lukas-reineke/indent-blankline.nvim' -- Add indentation guides even on blank lines
	use("rmehri01/onenord.nvim") -- onenord colorscheme
	use { 'nvim-telescope/telescope.nvim', requires = { 'nvim-lua/plenary.nvim' } } -- Fuzzy Finder (files, lsp, etc)
end)

from onenord.nvim.

rmehri01 avatar rmehri01 commented on August 23, 2024

Hmm interesting, thanks for sharing. It's strange how I can't seem to reproduce the issue even with this minimal setup but I think maybe that it's getting that blue from the default colorscheme because that's how it looks when I use it. In any case I can add the other highlights if it fixes the issue.

from onenord.nvim.

rmehri01 avatar rmehri01 commented on August 23, 2024

Can you confirm if this fixes it?

from onenord.nvim.

hacktivateit avatar hacktivateit commented on August 23, 2024

almost, the underline is yellow
image

from onenord.nvim.

rmehri01 avatar rmehri01 commented on August 23, 2024

My bad, I missed that it was also different.

from onenord.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.