rlch / github-notifications.nvim Goto Github PK

After installing the plugin i get a long error message in the neovim load like this:

Error in packer_compiled: /Users/leikoilja/.config/nvim/plugin/packer_compiled.lua:291: module 'config.github-notifications' not found:^@^Ino field package.preload['config.github-notifications']^@^Ino file './config/github-notifications.lua'^@^Ino file '/opt/homebrew/share/luajit-2.1.0-beta3/config/github-notifications.lua'^@^Ino file '/usr/local/share/lua/5.1/config/github-notifications.lua'^@^Ino file '/usr/local/share/l
ua/5.1/config/github-notifications/init.lua'^@^Ino file '/opt/homebrew/share/lua/5.1/config/github-notifications.lua'^@^Ino file '/opt/homebrew/share/lua/5.1/config/github-notifications/init.lua'^@^Ino file '/Users/leikoilja/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/config/github-notifications.lua'^@^Ino file '/Users/leikoilja/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/config/github-notifications/i
nit.lua'^@^Ino file '/Users/leikoilja/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/config/github-notifications.lua'^@^Ino file '/Users/leikoilja/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/config/github-notifications/init.lua'^@^Ino file './config/github-notifications.so'^@^Ino file '/usr/local/lib/lua/5.1/config/github-notifications.so'^@^Ino file '/opt/homebrew/lib/lua/5.1/config/gi
thub-notifications.so'^@^Ino file '/usr/local/lib/lua/5.1/loadall.so'^@^Ino file '/Users/leikoilja/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/lua/5.1/config/github-notifications.so'^@^Ino file './config.so'^@^Ino file '/usr/local/lib/lua/5.1/config.so'^@^Ino file '/opt/homebrew/lib/lua/5.1/config.so'^@^Ino file '/usr/local/lib/lua/5.1/loadall.so'^@^Ino file '/Users/leikoilja/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/l
ua/5.1/config.so'

The last line claims "please check your config for correctness", but i use very default setup, following README:

With that being said, the plugin seems to work ad shows me the GH notification on the bottom

Hi 👋🏿 ,

just stumbled upon this and it seems pretty cool, I've got a much smaller version of this in my statusline but I like the ability to open notifications in a telescope picker etc. One thing I noticed is that it requires a user to pass credentials explicitly in their config which is a little inconvenient and potentially could lead to exposing these.

In my dots I use gh api notifications which seems to work quite well and has the advantage that if a user has the github cli installed and setup then they can make this call without credentials i.e. they will already be auth'ed through the cli.

Currently it is not possible to filter the notifications within Telescope via fuzzy finding, which is a main part of Telescope's functionality.

As per the title, I get this error for some github notifications, not all..no idea why

E5108: Error executing lua ...ns.nvim/lua/github-notifications/telescope/previewer.lua:23: attempt to concatenate field 'url' (a userdata value)
stack traceback:
...ns.nvim/lua/github-notifications/telescope/previewer.lua:23: in function 'define_preview'
...scope.nvim/lua/telescope/previewers/buffer_previewer.lua:386: in function 'preview'
...pack/packer/opt/telescope.nvim/lua/telescope/pickers.lua:1075: in function 'refresh_previewer'
...pack/packer/opt/telescope.nvim/lua/telescope/pickers.lua:1028: in function 'set_selection'
...pack/packer/opt/telescope.nvim/lua/telescope/pickers.lua:792: in function 'move_selection'
.../packer/opt/telescope.nvim/lua/telescope/actions/set.lua:39: in function 'run_replace_or_original'
...k/packer/opt/telescope.nvim/lua/telescope/actions/mt.lua:65: in function 'shift_selection'
...packer/opt/telescope.nvim/lua/telescope/actions/init.lua:87: in function 'run_replace_or_original'
...k/packer/opt/telescope.nvim/lua/telescope/actions/mt.lua:65: in function 'key_func'
...ack/packer/opt/telescope.nvim/lua/telescope/mappings.lua:341: in function 'execute_keymap'
[string ":lua"]:1: in main chunk

Hi @rlch, thanks for getting the gh cli working 👍🏿 , I've now swapped out my custom statusline component with this plugin's. One thing I had in my implementation was a way of hiding the statusline element if there were no notifications since I personally prefer having each item in my statusline only visible if there is content/something actionable e.g. a count of > 0 etc. I wonder if this could either be offered as an option, but that might be too specific 🤷🏿‍♂️ or alternatively maybe the count and icon could be returned in a table similar to gitsigns e.g. {icon = "x", count = 1} or a user could pass their own formatter function.

The first I think would be simplest, but not sure if this would be too specific a use case to accommodate 🤷🏿‍♂️