Comments (4)
Hello Sergey,
I see this as a feature request, not a bug. I will also add a note to know limitations of the tool about this. This is how this tool worked also before, the only difference is that TLV 43.4 was not yet implemented before. I think it was not even developed by Cablelabs when Cisco/SA choosed subTLV 4 for their needs.
This happens because there is no check in place at this moment to check which vendor implementation of TLV 43.4 is in the config file. I implemented the Cablelabs Vendor Identifier but whenever a different vendor will try to use the same number, this problems can appear.
Nowadays vendor specific TLVs are not common anymore and vendors are using OIDs for their specific needs instead of TLVs. I also suggest that you should check with Cisco/SA if they have an OID which is doing the same configuration like TLV 43.4 and 43.6. If they have an OID, you can use the OID as a workaround instead of the TLV value.
You did not find "DOCSIS vendor specific Extension Field" in "docsis_symtable.h" because I did not implement that.
For whoever is interested to code this, we need to first check if we encode VendorID 0xffffff and only after that use the values from docsys_symtable, if the VendorID is different from 0xffffff we should consider all as being vendor independent and encode/decode as GenericTLV. I will think on a way to implement this feature but the architecture of the utility did not take into consideration that same TLVs can have different names and can be encoded different.
Best regards,
Adrian.
from docsis.
Sergey, please give it a try with the branch tlv43_vspecific which can be found in my fork on Github.
Here you have a link:
https://github.com/AdrianSimionov/docsis/archive/tlv43_vspecific.zip
Let me know if this fixes the issue you had. It seems to be working fine for me.
from docsis.
Adrian,
Thanks for the new version with tlv43_vspecific.
I built and checked the new docsis with my bootfiles and modems.
The Encode/decode are working and modems accept new bootfiles.
So you can add these changes to github.
from docsis.
I merged in the changes. I figure if AdrianSimionov did all the hard work, the least I can do is click a couple buttons to create a pull request and merge it. ;) Thanks AdrianSimionov, you are awesome!
from docsis.
Related Issues (20)
- TLV81 encoding issue. DOCSIS 3.1 SSD HOT 3
- Arris MTA configfile error HOT 7
- Backslash issue HOT 3
- Fail to encode IPv6 address HOT 1
- comment-in-comment not supportedFirst TLV is MtaConfigDelimiter, forcing PacketCable MTA file
- Encode file for negative value HOT 5
- Add certificate chain file import to TLV 81 and 82 in bootfile encoding
- PacketCable 2.0 dialplan OID (CL-PKTC-EUE-RST-MIB::pktcEUERSTDMValue) HOT 8
- BitString can be decoded but not encoded HOT 4
- Cannot run tests from clean clone HOT 3
- FrameLossMeasurementTransmissionPeriodicity incorrect data type HOT 1
- PKTC Config Hash HOT 24
- ip address length mismatch when decoding GenericTLV
- New TLV: 84 Diplexer Band Edge HOT 6
- Segfault when input is incorrect
- When encoding with empty MIC Key, PacketACE Refuses the file. HOT 4
- Issue in decoding configuration file
- clang: error: unknown argument HOT 7
- Installation to debian_10 HOT 2
- MIBs dynamically read or static? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docsis.