Git Product home page Git Product logo

Comments (8)

rlaager avatar rlaager commented on September 26, 2024

I'm not in any position to test this, so I'd have to take your word for it. But why would we want to use index 1 rather than 0 here?

from docsis.

mbowe-au avatar mbowe-au commented on September 26, 2024

I agree its a bit strange, as .0 is the usual way for OIDS in general.

However all of those OIDs in that region are .1

I believe they are references to other tables?

You can see it here https://www.excentis.com/blog/packetcable-20-edva-config-files

The item I am talking about is shown on line 47 in pink. See how it is a .1, and all the other indexes in that region are also .1 rather than the more usual .0

The docsis compiler works fine for all the other OIDs in this region, it is just this particular one that doesn't work properly. It has been hardcoded as a big hexstring to allow for that special encode/decode handling of the dialplan.txt file. I guess the person who wrote the hexstring just assumed .0 was the correct way? I don't think that using this tool for packetcable 2.0 is very common, so this might be a bug that has gone undiscovered so far.

I patched my local copy from .0 to .1 and then I could then correctly compile/decode the Packetcable 2.0 config files and dialplan.txt.

I can upload an example packetcable 2.0 mta config file if you need one for testing

[edit: minor change to try and improve clarity]

from docsis.

AdrianSimionov avatar AdrianSimionov commented on September 26, 2024

I specifically hardcoded it this way as this is the way chipset manufacturers implemented the PacketCable 2.0. It was done based on lab testing at LGI in Europe. If you have a specific use-case where .0 is used, check with the chipset manufacturer if they are following CableLabs. I guess we could think of an option where both .0 and .1 would be used but I would not just change .1 into .0

from docsis.

rlaager avatar rlaager commented on September 26, 2024

@AdrianSimionov It sounds like you have that backwards. The proposal here is to change it from .0 to .1.

from docsis.

AdrianSimionov avatar AdrianSimionov commented on September 26, 2024

I would not change it to .0 unless:

  1. there is a valid reason and there is a use-case which requires it. @mbowe-au , I assume your lab tests show that there are now chipset implementations with .0 index too?
  2. remains backwards compatible for the use-cases where .1 is the index in use.

from docsis.

rlaager avatar rlaager commented on September 26, 2024

@AdrianSimionov @mbowe-au wants to change it to .1. It is currently .0. It sounds like you think it is currently .1, so you're actually in agreement?

from docsis.

mbowe-au avatar mbowe-au commented on September 26, 2024

Sorry @AdrianSimionov , possibly my wording wasn't super clear. I have now made a small edit to my post to try and clarify.

I am saying the compiler is creating that OID as .0, when I think it is meant to be .1
And it sounds like you agree that .1 is correct.

from docsis.

AdrianSimionov avatar AdrianSimionov commented on September 26, 2024

From what I remember, it is .1 for PacketCable 2.0. All good from my side.

from docsis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.