riskified / ios_sdk Goto Github PK

We're curious on the strategy around naming releases with -b. Assuming the -b suffix indicates beta, it is confusing because there is a long list of releases where some don't have the -b while others do. There is no clear indication of a stable, non-beta release. The screenshot below shows some of this.

If you could kindly provide clarification on:

• What is the difference of a release suffixed with -b vs. a numerical one?
• Are releases suffixed with -b to be considered stable?
• Is there a plan where this becomes consistent in the future? SPM will pull in the highest numeric value when things are mixed like this... so it can have a project pull in a lower than intended version.

Hello,

Even if there is a specific release that supposedly was adding support for bitcode doing otool -v -s __LLVM __bundle BINARYPATH shows that there is no actual bitcode information.

Without bitcode we won't be able to update the framework. It would be great if we could support it. Thanks!

Any update about the privacy manifest file?

Updating to the latest iOS version in order to get the privacy manifest changes is causing issues when uploading build to app store connect.

Tried 1.40-b using a manual install, as well as using SPM - neither of which worked.

For now we have reverted to 1.3.4-b which is working, however this will need to be fixed for us before the deadline for Privacy Manifests is fully enforced by Apple otherwise this will become a blocker for release.

Hello, while the podspec included in this repo is correct, the one published is different and it includes:

  "user_target_xcconfig": {
    "EXCLUDED_ARCHS[sdk=iphonesimulator*]": "i386"
  },
  "pod_target_xcconfig": {
    "EXCLUDED_ARCHS[sdk=iphonesimulator*]": "i386"
  }

This is not required since the frameworks do not contain anymore that slices, and it can create issues with Cocoapods when having other xcframework with similar (but different values)

This issue is a native iOS issue that appears in the react native implementation of this sdk.

Screenshot

Official react native sdk:
https://www.npmjs.com/package/@riskified/react-native-riskified-sdk

The linked Github repo and homepage have been made private, I would suggest making them public so issues can be made there. https://github.com/Riskified/react-native-riskified-sdk

Steps to reproduce

1. Implement the react native sdk https://www.npmjs.com/package/@riskified/react-native-riskified-sdk

import { AppRegistry } from 'react-native';
import App from './App';
import { name as appName } from './app.json';

import RiskifiedSDK from '@riskified/react-native-riskified-sdk';

RiskifiedSdk.startBeacon(shopDomain, token, false);

AppRegistry.registerComponent(appName, () => App);

2. Open the app in a simulator
3. Refresh metro to reload the js

You should see the error pop up since the app is reloaded and the js code is run again.

The current release does not support developing on Apple Silicon Macs. The .a file does not contain object files for arm64 Simulator builds.

As per title, the static library still support arm7 and not arm64.
Or if the .a is no longer supported, then it is a bit misleading.

Analysing the 1.3.0 update, I've noticed a great increase in the xcframework bundle size. Looking closely, the framework now carries Swift standard libraries. These should be only bundled to the target app if needed (and deploying to iOS 12.3 and earlier OS versions) or not at all as for later deployment targets, Swift 5 ABI compatibility handles it.

Please rebuild the xcframework without the Swift standard libraries bundled. 👍

The package name "ios_sdk" is way too generic, and we can't implement it as we already have a dependency with the same name.
Could you update the package name to include the name of your product and prevent conflicts ?

Now that SPM supports XCFrameworks, any chance Riskified could add SPM support?

Hi I have implemented the sdk and on running of the startBeacon method I am getting a crash - EXC_BAD_ACCESS (code=2,.....) [RXController get locationInfo].
Would appreciate the inputs