Comments (13)
I will update the package soon
from rigs-of-rods.
I found out where I fixed it in PagedGeom.
https://github.com/stuntrally/stuntrally/blob/master/source/paged-geom/GrassLoader.cpp#L130
Main part here:
void GrassLoader::loadPage(PageInfo &page)
{
//Generate meshes
bool first = true; ///T
std::list<GrassLayer*>::iterator it;
for (it = layerList.begin(); it != layerList.end(); ++it)
{ GrassLayer *layer = *it;
if (first) ///T once for all layers
layer->parent->rTable->resetRandomIndex();
first = false;
We have PagedGeom sources inside old SR, this is an older fork of it.
My changes are marked with ///T
, could be useful to check them all.
Probably all those later are needed to fix this too:
commenting out: //parent->rTable->resetRandomIndex();
so:
https://github.com/stuntrally/stuntrally/blob/master/source/paged-geom/GrassLoader.cpp#L868
https://github.com/stuntrally/stuntrally/blob/master/source/paged-geom/GrassLoader.cpp#L936
https://github.com/stuntrally/stuntrally/blob/master/source/paged-geom/GrassLoader.cpp#L1009
from rigs-of-rods.
To be honest, I think the PaGeom grass is ugly and unoptimal either way. PaGeom itself is weird:
-"trees" really means custom meshes of any kind- but it only makes sense if they use same mat which isn't really emphasized in doc.
-"grass" is this ugly hardcoded 2 polys crossed. So 90's. Today even potato chip handles more polys as long as they're one draw call.
-recently I coded a scene inspector and noticed PaGeom inserts and shuffles thousands of scene nodes. I haven't investigated further but I got the impression each grass clump is an entity which feels horrific.
Personally I'd rather dump Paged grass altogether and used the #3030 feats to generate more detailed grass in bigger batches, possibly using the shell texturing trick or combined
from rigs-of-rods.
Sure, I agree PagedGeom is the worst now. But this is a quick fix for current issue.
Is the new system for grass something that will happen soon? If so I'll wait. If not then I'd say this is worth fixing.
I'm also confused if there is any roadmap or release timeline for all these PRs with improvements etc?
from rigs-of-rods.
The new system for grass will come as side effect of #3030 that I keep pointing you to :) I'm intensively focusing on that and it will be done at the end of February latest, though probably earlier.
Though yes, a quick fix for the PagedGrass would be good. But we have paged sources outside of our tree: https://github.com/RigsOfRods/rigs-of-rods/blob/master/conanfile.py#L20 and IIRC the Loader
system was somewhat modular, so maybe the way to go is to create custom loader with these updates.
I'm sure the community would appreciate a roadmap but I was never able to follow one, I get incredibly frustrated fixing the minor glitches that bother players and I escape to more fundamental things that the community hardly cares about. But most importantly, I'm the only dev around who's able to look at the codebase hollisitically, others just do narrow (though major in gameplay/quality-of-life gain) features.
from rigs-of-rods.
Ah okay. Yeah there is so much stuff in #3030 that I didn't expect grass there too :)
Okay I'll wait for that, will be easier.
I'm not keen with dependencies. It seems like I'd need to submit patch for official paged-geom and then AnotherFoxGuy would need to update script etc. Not needed, if you'll just ditch paged-geom so soon.
from rigs-of-rods.
Well thats my wishful thinking anyway. I'll create a prototype grass generator soon, but I can't predict how the community will react, the paged grass isnt ugly 100% of the time.
@AnotherFoxGuy how would you approach this? Create a patched Conan package or try to override GrassLoader in game source?
from rigs-of-rods.
@ohlidalp Why not submit the patch upstream?
For the OGRE 1.11 version we still use our own fork of paged-geom
from rigs-of-rods.
Ah good. Where is it?
from rigs-of-rods.
Ah good. Where is it?
We use this repo: https://github.com/RigsOfRods/ogre-pagedgeometry
from rigs-of-rods.
Ok made a PR
RigsOfRods/ogre-pagedgeometry#15
from rigs-of-rods.
Merged in good faith - I didn't find time to build it.
from rigs-of-rods.
Okay. @AnotherFoxGuy this probably needs updating deps right, could you do it?
I checked last dev build and it still looks the same with grass.
from rigs-of-rods.
Related Issues (20)
- Building for Fedora Core 38 HOT 5
- Flares3 Behavior HOT 2
- lib/libXt.so.6 file too short error HOT 9
- Add input sources for cruise control for the dashboard system HOT 3
- Rigs of rods repository HOT 16
- in-game repository is not working HOT 5
- Keyboard steering sensitivity HOT 11
- Some cars can't start race HOT 4
- Tuning system glitches and shortcomings HOT 7
- Race improvements HOT 8
- Lights=None in RoR.cfg crash air vehicles loading HOT 3
- Favorite vehicles/terrains HOT 4
- Add release on flathub.org (flatpak) HOT 8
- Fog distance cuts off clouds far HOT 10
- Waves on water is broken HOT 9
- Display Scaling is COMPLETLY BROKEN. HOT 29
- setEventSimulatedValue does not work in multiplayer while server bot is present
- Texture conflicts between mods HOT 2
- Alternative mods folder location HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rigs-of-rods.