Git Product home page Git Product logo

righton-app's People

Contributors

alexandra-kushnirsky avatar alexandrakushnirsky avatar amanbhandal avatar amarax avatar ankittrehan2000 avatar dependabot[bot] avatar drewjhart avatar ericnguyen-b avatar friendly-robot avatar guofoo avatar jjackson914 avatar josephinaim avatar lucahendicott avatar maniramezan avatar neuveltp avatar rwu603 avatar ryanabooth avatar sincwu avatar zach2025 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

righton-app's Issues

Create web portal to help testing the mobile app

During testing phase, it'd be hard to keep starting and ending games since that requires access to two devices and soon, it'd be time consuming to test a simple scenario or fix a bug. This proposes to create a web portal where it helps with testing the app like starting a game and modifying some aspects of started game.

[Mobile] Look into Relay

Relay is a library that can be used with GraphQL to improve the performance. Lets look into this library since it's about the time to start integrating with backend and see if this is something that should be used.

Create JSLint

Create jslint rule or a way to automate formatting rules

[Entering Trick Answers] Remove the spinning timer component from the Trick Answers card (and keep it for just the Hints card)

Background: To encourage students to think about the correct answer and come up with plausible / non-random trick answers, we've added a prompt for them to try to first try to guess the correct answer. If guesses at the correct answer are incorrect, an encouraging note is displayed, reminding students that answers that they thought were correct but are actually incorrect are great potential trick answers.

Since we'd like students to start thinking about the question and potential correct answers right away, please remove the spinning timer component from the Trick Answers card (and keep it for just the Hints card) -- thanks!

[Non-Facilitator Flow] Incorrect Message Displayed

Expected behavior: in the non-Facilitator flow, when the Trick Answers card is first displayed, the following message should be displayed: "What do you think the correct answer is?" For the latest messages, please reference the "Student Screens - Updated Trick Answer Flow" tab in Figma.

Actual behavior: the message for Facilitators appears: "Help guide your team to guess the correct answer!" (see attached screenshot)

Testing was conducted on an Android device (Galaxy S7)
image
.

Create a config file to download from backend

At the moment, there are two values need to be able to modify at runtime

  • Score for popular answer
  • Score for trick answers

There might be more options coming in. Since the implementation is in React Native, there needs to be investigation on using RN push vs. config file endpoint.

P2: When voting results are displayed (bottom to top), the bottom row should contain the least popular answer, etc.

When voting results are displayed (bottom to top), the bottom row should contain the least popular answer (lowest percentage of votes) and the top row should contain the most popular answer (highest percentage of votes).

In the attached screenshot:

  • "540" seems to have 0% and should thus appear in the bottom row (when an answer has received no votes, please still show 0% in the right column and no corresponding "progress bar" in the left)
  • In the particular screenshot, the answers from top to bottom should be: 1) 8 (89%), 2) 360 (10%), 3) 1080 (1%), 4) 540 (%)

Screenshot_20210119-121128_RightOn

P3: Delay in 1st Trick Answer Appearing in List of Trick Answers

12/9 Build:

  • Great progress in this build with the trick answer component!
  • In both the Facilitator & non-Facilitator flows: after the first trick answer is submitted, there's a noticeable delay (~2-3 seconds) before that trick answer appears in the list of trick answers.
  • This issue seems to affect only the 1st trick answer (the 2nd, 3rd, and all subsequent trick answers seem to appear OK -- virtually instantaneously in the list of trick answers after being submitted).

[July 7][Mobile] Create networking framework

In the beginning of integrating with backend, it'd be nice to be able to create a networking library which does the API calls instead of putting all these API calls in the app and components. In addition to better separation of concerns, this can be shared with #90 to reduce the code duplication and make it easier to create debug portal.

[July 21][Mobile] Integrate Redux into mobile app

Currently, mobile app doesn't follow any pattern for data flow and it's using mock data. As moving forward with integrating with backend APIs, the infrastructure for handling the data properly needs to be put into the place.

Update README

The top level README should not be a description of the mobile app.

Trick answers, once added, should be read-only and have a larger clickable area for Facilitators

In the July 14 build:
When a trickster team is entering trick answers: once a trick answer is added to the list of trick answers, it:

  1. Should be read-only (i.e., not editable or deletable)
  2. Have a larger clickable area (e.g., the entire button)

Please also apply this update to the "Don't Get Tricked" / voting screens where student teams try to vote for the correct answer (and try not to be tricked by the trickster team's trick answers).

[Viewing List of Trick Answers] Vertical scrolling appears to get stuck at times

In the Trick Answers card: the vertical scrolling functionality seems to get stuck at times: e.g., after a trick answer has been added, one sometimes has to wait multiple seconds to be able to scroll up & down -- the screen appears to freeze, and it'd be great if the scrolling could be more instantaneous (ideally as quick and responsive as when one swipes left/right to navigate between the Question, Trick Answers, and Hints cards).

Steps to Reproduce:

  1. As a non-Facilitator, enter five trick answers: e.g., 135, 246, 357, 468, 579.
  2. When the 3rd trick answer has been entered, one has to scroll to be able to see all trick answers in entirety.
  3. Starting from the 3rd trick answer and for subsequently entered trick answers, the vertical scrolling functionality can be a bit choppy, often appearing to freeze. Sometimes, right after a trick answer has been entered, one is able to scroll down and see the full list; however, upon trying to scroll back up, the screen can freeze. The delay can be several seconds, appearing as an intermittent freezing/crash.

Testing was conducted on an Android device (Galaxy S7).

[Apr 21] Hook App Sync app up to RDS data source

Overview of tasks:

  • Set up Data API for the database
  • edit the existing app sync app's (web) data sources
  • make a new action with an RDS resolver
  • test the new endpoint in the playground

I got caught in the first step because I forgot the password of the Aurora database. πŸ˜† We can reset it, or create a new database with a snapshot of the existing schema.

[Entering Trick Answers] After an incorrect/trick answer has been entered, the "What do you think the correct answer is?" field should be cleared

July 14 build:

Observed:
Currently, after an incorrect/trick answer has been entered (e.g., "123" in the attached screenshot), "123" still appears in the "What do you think the correct answer is?" field.

Expected:
After an incorrect/trick answer has been entered (e.g., "123" in the attached screenshot), the "What do you think the correct answer is?" field should be cleared.

Note: After the wait time for hints has passed (and students are then able to view the hints and the correct answer in the Hints card), the "What do you think the correct answer is?" field will be different -- there will instead be a message that reminds students what the correct answer is.

image

Treat numbers, whether entered with commas or not, as equivalent

When a user enters 1) a guess at the correct answer before the correct answer has been revealed or 2) a trick answer after the correct answer has been revealed: treat numbers, whether entered with commas or not, as equivalent.

For example, in the scenario below, "1080" is the correct answer. However, when "1,080" is entered before the correct answer has been revealed, "1,080" is identified as a wrong answer and added to the trick answer list. When "1,080" is entered after the correct answer has been entered/revealed, "1,080" is accepted as a trick answer even though it is equivalent to the correct answer.

This issue tracks just the handling of commas. In the future, we may want to think about handling other equivalences -- e.g., 2/4 = 1/2 = 0.5.

image

[Facilitator Flow] Facilitator should not be able to enter trick answers or guesses at the correct answer.

In the Facilitator flow, the facilitator can currently still enter trick answers / guesses at the correct answer.

  • In the multi-device scenario, one device is randomly assigned to be the Facilitator, and the Facilitator's role is to make sure that the team enters at least 3 trick answers; when 4 or more trick answers are entered by the team, the Facilitator selects three. Please note that the Facilitator cannot enter trick answers or guesses at the correct answer.
  • In the single-device scenario, there is no Facilitator, and that single device will naturally be able to enter trick answers / guesses at the correct answer.

To be able to test the part of the Facilitator flow where the Facilitator is able to select/unselect trick answers entered by other team members, we will naturally need a way to enter those trick answers. Before back-end functionality is enabled, we can just keep the current functionality as-is for testing purposes. Later down the road, when back-end / multi-device functionality has been enabled: the trick answers entered by non-Facilitator users should then also appear in the Facilitator's view for the Facilitator to select/unselect.

Testing was conducted on an Android device (Galaxy S7).

Line wrapping issue for game titles

When game titles are too long, there is a line wrapping issue when only half the title is rendered.

For example, "Excellent Exponents" is rendered properly but "Copy of Excellent Exponents" might not be displayed all the way.

Outdated library versions with security vulnerabilities

npm audit in the project directory reveals several Denial of Service vulnerabilities known to exist in the versions of the libraries we're using. Updating these libraries should fix the vulnerabilities, but some updates may include breaking API changes. This fix should be tested in its own branch before merging into master.

Integrate with fastlane

Integrate the mobile app with fastlane to automate build process. Currently, the build is done manually and uploaded to AppCenter and Testflight. Further more, we should look into Github actions.

"Don't Get Tricked" screen shows Hints card

Observed

"Don't Get Tricked" screen shows the Hints card
Screenshot on iPhone X:
IMG_C4A699909493-1

Expected

"Don't Get Tricked" screen doesn't show the Hints card, only Question and Choose One cards.

P3: When guessing the correct answer: if an incorrect answer is entered, the "Nice try!..." message should disappear after X seconds

12/9 Build:

Expected behavior:
When guessing the correct answer (before the hints have been revealed): if an incorrect answer is entered, the "Nice try! That's not the correct answer, but it sounds like a great trick answer! We've added it to your list of trick answers!" message should disappear after X seconds (X = a variable that can be adjusted as needed). Please see Figma screens below.

image

Observed behavior:
The "Nice try!..." message appears to remain permanently.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.