Git Product home page Git Product logo

compaero's Issues

Needs more well thought out examples

A good addition to the repo would be to add some more well-thought examples. Perhaps some from a textbook that demonstrates each part of the library.

Bring library up to PEP8 standards

As the title says. Update all code to PEP8 standards.

  • Add a code formatter
  • set line length to 100 instead of 80 (80 is annoying short especially with large monitors which are common)
  • change all camel case code to snake case

Add a UI

It may be beneficial to add a UI to make the class easier to use if only a simple calculation is needed. The layout would probably be similar to the VT calculator.

Support Standard Atmosphere

Add support for the standard atmosphere tables in the same class-like manner that compressible flow was implemented.

  • Add support
  • Add tests
  • Add documnetation
  • Add unit conversions (Maybe its own feature)

Oblique Shock Case

One of the valid initialization scenarios involves gamma, m2, shock angle, and wedge angle being valid. When implementing this in the UI I noticed that these results were inconsistent. Is it valid that this class can be initialized with that?

Support Multiple Values in constructor

Add the capability to give each variable as a list or NumPy array to calculate a range of values.

  • Add support for feature, while not breaking existing
  • Update documentation
  • Add tests

Add checks for valid inputs

Some of the functions dont have any checks regarding input validation. I.E some functions are really only valid if the mach number is greater than 1. Checks need put in place for these functions and tests need to be written for them.

Fanno Flow Relations Issue

The same value calculated with the option "gamma, Mach" cannot be reduplicated when option "gamma, T/T*" is selected. It seems that the value for T/T* can be calculated from the mach number but the mach number cannot be backed out from that same T/T*.

Steps to reproduce.

  1. Go to Fanno Flow Tab in the UI
  2. Set Gamma = 1. 4 and Mach = 3 Option = "Gamma, Mach"
  3. Calculate
  4. Change option to "Gamma, T/T*" and calculate
  5. Observe crash.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.